Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2341323003: cc: Add temporary CHECKs to debug TileManager crash. (Closed)

Created:
4 years, 3 months ago by vmpstr
Modified:
4 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add temporary CHECKs to debug TileManager crash. This patch adds checks to see which call site is invoking a CheckAndIssueSignals without a tile_task_manager_. Code inspection didn't point at any obvious culprits. Hopefully these checks will. R=danakj BUG=642927 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/82c838932d529fd704b2c7c6484e3bf9a6bea600 Cr-Commit-Position: refs/heads/master@{#419348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M cc/tiles/tile_manager.cc View 5 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vmpstr
Please take a look.
4 years, 3 months ago (2016-09-16 23:25:01 UTC) #2
danakj
LGTM
4 years, 3 months ago (2016-09-16 23:27:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341323003/1
4 years, 3 months ago (2016-09-16 23:30:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-17 00:34:07 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 00:41:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82c838932d529fd704b2c7c6484e3bf9a6bea600
Cr-Commit-Position: refs/heads/master@{#419348}

Powered by Google App Engine
This is Rietveld 408576698