Simplify Scanner bookmarking.

Simplify Scanner bookmarking.

- Eliminates *all* copies in the process.
- Moves (nearly) all functionality into Scanner::BookmarkScope.
- Significant code reduction.

[Needs to be rebased once crrev.com/2347883002 lands. All changes in *parser* are from that CL.]

R=marja@chromium.org
BUG=v8:4947
Committed: https://crrev.com/05a00a93b1cc2c86ba5e249f8b1fba57a15c2a97
Cr-Commit-Position: refs/heads/master@{#39554}

[vogelheim, 2016-09-16 16:11:19]

The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 16:11:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vogelheim, 2016-09-16 16:13:59]

Description was changed from

==========
Simplify Scanner bookmarking.

- Eliminates *all* copies in the process.
- Moves (nearly) all functionality into Scanner::BookmarkScope.
- Significant code reduction.

[Needs to be rebased once crrev.com/2347883002 lands.]

R=marja@chromium.org
BUG=v8:4947
==========

to

==========
Simplify Scanner bookmarking.

- Eliminates *all* copies in the process.
- Moves (nearly) all functionality into Scanner::BookmarkScope.
- Significant code reduction.

[Needs to be rebased once crrev.com/2347883002 lands. All changes in *parser*
are from that CL.]

R=marja@chromium.org
BUG=v8:4947
==========

[vogelheim, 2016-09-16 16:35:06]

ptal

[commit-bot: I haz the power, 2016-09-16 16:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 16:41:20]

Dry run: This issue passed the CQ dry run.

[marja, 2016-09-19 07:50:22]

lgtm w/ comment

https://codereview.chromium.org/2341323002/diff/1/src/parsing/scanner.cc
File src/parsing/scanner.cc (right):

https://codereview.chromium.org/2341323002/diff/1/src/parsing/scanner.cc#newc...
src/parsing/scanner.cc:43: void Scanner::BookmarkScope::Reset() {
IMO "Reset" is not the correct name for this function. "Reset" means more like
"clear the current value", whereas this actually takes the bookmark into use!
How about Apply?

https://codereview.chromium.org/2341323002/diff/1/src/parsing/scanner.cc#newc...
src/parsing/scanner.cc:54: return bookmark_ == kBookmarkWasApplied;
... here you already use the term "apply" :)

[vogelheim, 2016-09-20 10:49:47]

Patchset #2 (id:20001) has been deleted

[vogelheim, 2016-09-20 11:41:56]

The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 11:42:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vogelheim, 2016-09-20 11:52:44]

https://codereview.chromium.org/2341323002/diff/1/src/parsing/scanner.cc
File src/parsing/scanner.cc (right):

https://codereview.chromium.org/2341323002/diff/1/src/parsing/scanner.cc#newc...
src/parsing/scanner.cc:43: void Scanner::BookmarkScope::Reset() {
On 2016/09/19 07:50:22, marja wrote:
> IMO "Reset" is not the correct name for this function. "Reset" means more like
> "clear the current value", whereas this actually takes the bookmark into use!
> How about Apply?

Done.

https://codereview.chromium.org/2341323002/diff/1/src/parsing/scanner.cc#newc...
src/parsing/scanner.cc:54: return bookmark_ == kBookmarkWasApplied;
On 2016/09/19 07:50:22, marja wrote:
> ... here you already use the term "apply" :)

Done.

[commit-bot: I haz the power, 2016-09-20 12:11:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 12:11:46]

Dry run: This issue passed the CQ dry run.

[vogelheim, 2016-09-20 13:31:53]

The CQ bit was checked by vogelheim@chromium.org

[vogelheim, 2016-09-20 13:31:53]

The patchset sent to the CQ was uploaded after l-g-t-m from marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2341323002/#ps40001
(title: "feedback, rebase, plus fix bug")

[commit-bot: I haz the power, 2016-09-20 13:32:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 13:47:37]

Description was changed from

==========
Simplify Scanner bookmarking.

- Eliminates *all* copies in the process.
- Moves (nearly) all functionality into Scanner::BookmarkScope.
- Significant code reduction.

[Needs to be rebased once crrev.com/2347883002 lands. All changes in *parser*
are from that CL.]

R=marja@chromium.org
BUG=v8:4947
==========

to

==========
Simplify Scanner bookmarking.

- Eliminates *all* copies in the process.
- Moves (nearly) all functionality into Scanner::BookmarkScope.
- Significant code reduction.

[Needs to be rebased once crrev.com/2347883002 lands. All changes in *parser*
are from that CL.]

R=marja@chromium.org
BUG=v8:4947
==========

[commit-bot: I haz the power, 2016-09-20 13:47:37]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-20 13:48:12]

Description was changed from

==========
Simplify Scanner bookmarking.

- Eliminates *all* copies in the process.
- Moves (nearly) all functionality into Scanner::BookmarkScope.
- Significant code reduction.

[Needs to be rebased once crrev.com/2347883002 lands. All changes in *parser*
are from that CL.]

R=marja@chromium.org
BUG=v8:4947
==========

to

==========
Simplify Scanner bookmarking.

- Eliminates *all* copies in the process.
- Moves (nearly) all functionality into Scanner::BookmarkScope.
- Significant code reduction.

[Needs to be rebased once crrev.com/2347883002 lands. All changes in *parser*
are from that CL.]

R=marja@chromium.org
BUG=v8:4947

Committed: https://crrev.com/05a00a93b1cc2c86ba5e249f8b1fba57a15c2a97
Cr-Commit-Position: refs/heads/master@{#39554}
==========

[commit-bot: I haz the power, 2016-09-20 13:48:13]

Patchset 2 (id:??) landed as
https://crrev.com/05a00a93b1cc2c86ba5e249f8b1fba57a15c2a97
Cr-Commit-Position: refs/heads/master@{#39554}