fuzzers: add a fuzzer for the ANGLE shader translator

fuzzers: add a fuzzer for the ANGLE shader translator

BUG=angleproject:1522
Committed: https://crrev.com/98bea5472ae292ed699c3ecdb7512cee1de5904a
Cr-Commit-Position: refs/heads/master@{#420408}

[Corentin Wallez, 2016-09-16 14:35:13]

cwallez@chromium.org changed reviewers:
+ mmoroz@chromium.org

[Corentin Wallez, 2016-09-16 14:35:13]

PTAL, putting the ANGLE translator among the other orphan fuzzers.

[mmoroz, 2016-09-18 12:19:19]

LGTM, thanks!

[mmoroz, 2016-09-18 12:19:24]

The CQ bit was checked by mmoroz@chromium.org

[commit-bot: I haz the power, 2016-09-18 12:19:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-18 12:22:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-18 12:22:03]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[mmoroz, 2016-09-18 13:22:03]

The CQ bit was checked by mmoroz@chromium.org

[commit-bot: I haz the power, 2016-09-18 13:22:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-18 13:24:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-18 13:24:43]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmoroz, 2016-09-18 15:30:40]

On 2016/09/18 13:24:43, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
>   chromeos_amd64-generic_chromium_compile_only_ng on
> master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
>   linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Looks like you need to rebase your CL locally onto origin/master, then re-upload
the patchset.

[mmoroz, 2016-09-18 15:35:30]

On 2016/09/18 15:30:40, mmoroz wrote:
> On 2016/09/18 13:24:43, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
> >   chromeos_amd64-generic_chromium_compile_only_ng on
> > master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
> >   linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
> (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> >   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> Looks like you need to rebase your CL locally onto origin/master, then
re-upload
> the patchset.

I've just noticed that you already have fuzzer_test target for that fuzzer:
https://cs.chromium.org/chromium/src/third_party/angle/BUILD.gn?q=%22translat...

That's enough, the fuzzer is working:
https://cluster-fuzz.appspot.com/fuzzerstats?fuzzer_name=libfuzzer_translator...

That means, we just need to rename the fuzzer in third_party/angle/BUILD.gn and
add libfuzzer_options there (if you need that).  Do I miss anything?

[mmoroz, 2016-09-18 15:38:46]

On 2016/09/18 15:35:30, mmoroz wrote:
> On 2016/09/18 15:30:40, mmoroz wrote:
> > On 2016/09/18 13:24:43, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
> > >
> >
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
> > >   chromeos_amd64-generic_chromium_compile_only_ng on
> > > master.tryserver.chromium.linux (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
> > >   linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
> > (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> > >   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> > 
> > Looks like you need to rebase your CL locally onto origin/master, then
> re-upload
> > the patchset.
> 
> I've just noticed that you already have fuzzer_test target for that fuzzer:
>
https://cs.chromium.org/chromium/src/third_party/angle/BUILD.gn?q=%22translat...
> 
> That's enough, the fuzzer is working:
>
https://cluster-fuzz.appspot.com/fuzzerstats?fuzzer_name=libfuzzer_translator...
> 
> That means, we just need to rename the fuzzer in third_party/angle/BUILD.gn
and
> add libfuzzer_options there (if you need that).  Do I miss anything?

Ah, I see that you made it a source_set instead of fuzzer_test to make your GN
configuration work separately from Chromium. That makes sense. By the way, you
probably want to remove "import("//testing/libfuzzer/fuzzer_test.gni")" line
from angle/BUILD.gn file as well.

[Corentin Wallez, 2016-09-19 14:00:35]

On 2016/09/18 at 15:38:46, mmoroz wrote:
> On 2016/09/18 15:35:30, mmoroz wrote:
> > On 2016/09/18 15:30:40, mmoroz wrote:
> > > On 2016/09/18 13:24:43, commit-bot: I haz the power wrote:
> > > > Try jobs failed on following builders:
> > > >   linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
> > > >
> > >
> >
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
> > > >   chromeos_amd64-generic_chromium_compile_only_ng on
> > > > master.tryserver.chromium.linux (JOB_FAILED,
> > > >
> > >
> >
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
> > > >   linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
> > > (JOB_FAILED,
> > > >
> > >
> >
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> > > >   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
> > > >
> > >
> >
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> > > 
> > > Looks like you need to rebase your CL locally onto origin/master, then
> > re-upload
> > > the patchset.
> > 
> > I've just noticed that you already have fuzzer_test target for that fuzzer:
> >
https://cs.chromium.org/chromium/src/third_party/angle/BUILD.gn?q=%22translat...
> > 
> > That's enough, the fuzzer is working:
> >
https://cluster-fuzz.appspot.com/fuzzerstats?fuzzer_name=libfuzzer_translator...
> > 
> > That means, we just need to rename the fuzzer in third_party/angle/BUILD.gn
and
> > add libfuzzer_options there (if you need that).  Do I miss anything?
> 
> Ah, I see that you made it a source_set instead of fuzzer_test to make your GN
configuration work separately from Chromium. That makes sense. By the way, you
probably want to remove "import("//testing/libfuzzer/fuzzer_test.gni")" line
from angle/BUILD.gn file as well.

Thanks, however removing it makes use_libfuzzer not defined. I will leave things
at source_set + include for now and will figure out how to define use_libfuzzer
in standalone builds when I do the standalone GYP -> GN migration.

Currently waiting for an ANGLE roll to rebase + land this CL.

[Corentin Wallez, 2016-09-22 15:52:36]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2016-09-22 15:52:37]

The patchset sent to the CQ was uploaded after l-g-t-m from mmoroz@chromium.org
Link to the patchset: https://codereview.chromium.org/2341313002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-22 15:52:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 16:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 16:42:09]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Corentin Wallez, 2016-09-22 17:36:01]

On 2016/09/22 at 16:42:09, commit-bot wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Failures seems unrelated. Trying again.

[Corentin Wallez, 2016-09-22 17:36:09]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:36:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 18:52:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 18:55:58]

Description was changed from

==========
fuzzers: add a fuzzer for the ANGLE shader translator

BUG=angleproject:1522
==========

to

==========
fuzzers: add a fuzzer for the ANGLE shader translator

BUG=angleproject:1522

Committed: https://crrev.com/98bea5472ae292ed699c3ecdb7512cee1de5904a
Cr-Commit-Position: refs/heads/master@{#420408}
==========

[commit-bot: I haz the power, 2016-09-22 18:55:59]

Patchset 2 (id:??) landed as
https://crrev.com/98bea5472ae292ed699c3ecdb7512cee1de5904a
Cr-Commit-Position: refs/heads/master@{#420408}