Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2341273002: Prune some unnecessary calls to createVisiblePositionDeprecated (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, groby+blinkspell_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune some unnecessary calls to createVisiblePositionDeprecated This patch prunes createVisiblePositionDeprecated from the following files because callers there have already ensured clean layout: - TextIterator.cpp - PendingSelection.cpp - PlainTextRange.cpp - SelectionModifier.cpp - serializers/StyledMarkupSerializer.cpp - SpellChecker.cpp - TextCheckingParagraph.cpp - LocalFrame.cpp BUG=647219 Committed: https://crrev.com/467515a671ce9a7cadafee4ddcc57b0a804e5d60 Cr-Commit-Position: refs/heads/master@{#419663}

Patch Set 1 #

Patch Set 2 : Include LocalFrame::rangeForPoint #

Messages

Total messages: 16 (11 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-16 14:55:00 UTC) #10
tkent
lgtm
4 years, 3 months ago (2016-09-20 00:35:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341273002/20001
4 years, 3 months ago (2016-09-20 00:36:04 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 02:54:46 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 02:58:00 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/467515a671ce9a7cadafee4ddcc57b0a804e5d60
Cr-Commit-Position: refs/heads/master@{#419663}

Powered by Google App Engine
This is Rietveld 408576698