chrome/browser/resources/settings/printing_page/cups_printer_details_page.html - Issue 2341263003: [CUPS] Fix the Printer protocol string that displays in the UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/printing_page/cups_printer_details_page.html

Issue 2341263003: [CUPS] Fix the Printer protocol string that displays in the UI. (Closed)

Patch Set: Address michaelpg@'s comments. Rebase. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/printing_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/printing_page/cups_printer_details_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">	1 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html">

2 <link rel="import" href="chrome://resources/html/polymer.html">	2 <link rel="import" href="chrome://resources/html/polymer.html">

3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">	3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">

4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">

5 <link rel="import" href="/settings_shared_css.html">	5 <link rel="import" href="/settings_shared_css.html">

6	6

7 <dom-module id="settings-cups-printer-details-page">	7 <dom-module id="settings-cups-printer-details-page">

8 <template>	8 <template>

9 <style include="settings-shared">	9 <style include="settings-shared">

10 paper-input {	10 paper-input {

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 <div class="list-frame vertical-list">	44 <div class="list-frame vertical-list">

45 <div class="list-item setting-box two-line">	45 <div class="list-item setting-box two-line">

46 <div class="start">	46 <div class="start">

47 <div>$i18n{printerAddress}</div>	47 <div>$i18n{printerAddress}</div>

48 <div class="secondary">[[printer.printerAddress]]</div>	48 <div class="secondary">[[printer.printerAddress]]</div>

49 </div>	49 </div>

50 </div>	50 </div>

51 <div class="list-item setting-box two-line">	51 <div class="list-item setting-box two-line">

52 <div class="start">	52 <div class="start">

53 <div>$i18n{printerProtocol}</div>	53 <div>$i18n{printerProtocol}</div>

54 <div class="secondary">[[printer.printerProtocol]]</div>	54 <div class="secondary">

	55 [[getPrinterProtocol_(printer.printerProtocol)]]

	56 </div>

55 </div>	57 </div>

56 </div>	58 </div>

57 </div>	59 </div>

58 </iron-collapse>	60 </iron-collapse>

59 </template>	61 </template>

60 <script src="cups_printer_details_page.js"></script>	62 <script src="cups_printer_details_page.js"></script>

61 </dom-module>	63 </dom-module>

OLD	NEW