Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2341233002: Replace NULL with nullptr in WebSocket code in net/socket/ (Closed)

Created:
4 years, 3 months ago by tyoshino (SeeGerritForStatus)
Modified:
4 years, 2 months ago
Reviewers:
yhirano
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace NULL with nullptr in WebSocket code in net/socket/ R=yhirano@chromium.org BUG=none Committed: https://crrev.com/8d0a72022a5d2a09024fd46d27c60515b3467371 Cr-Commit-Position: refs/heads/master@{#423075}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -44 lines) Patch
M net/socket/websocket_endpoint_lock_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/websocket_transport_client_socket_pool.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M net/socket/websocket_transport_client_socket_pool_unittest.cc View 10 chunks +19 lines, -37 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tyoshino (SeeGerritForStatus)
4 years, 2 months ago (2016-10-04 13:24:42 UTC) #3
yhirano
lgtm
4 years, 2 months ago (2016-10-05 00:17:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341233002/20001
4 years, 2 months ago (2016-10-05 03:40:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 04:33:51 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 04:36:09 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d0a72022a5d2a09024fd46d27c60515b3467371
Cr-Commit-Position: refs/heads/master@{#423075}

Powered by Google App Engine
This is Rietveld 408576698