Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3428)

Unified Diff: chrome/browser/ui/views/website_settings/permission_prompt_impl.cc

Issue 2341213004: permissions prompt: use unicode hostname, not IDN (Closed)
Patch Set: display_url -> displayUrl Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
index 7045b6cf219a066dae2f2932bfa0131c476846f2..5160c759df2f2551b816025e313c129366e5ba06 100644
--- a/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
@@ -20,6 +20,7 @@
#include "chrome/grit/generated_resources.h"
#include "components/strings/grit/components_strings.h"
#include "components/url_formatter/elide_url.h"
+#include "components/url_formatter/url_formatter.h"
#include "ui/accessibility/ax_view_state.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/models/combobox_model.h"
@@ -201,6 +202,10 @@ PermissionsBubbleDialogDelegateView::PermissionsBubbleDialogDelegateView(
display_origin_ = url_formatter::FormatUrlForSecurityDisplay(
requests[0]->GetOrigin(),
url_formatter::SchemeDisplay::OMIT_CRYPTOGRAPHIC);
+ if (base::IsStringASCII(display_origin_)) {
+ display_origin_ = url_formatter::IDNToUnicode(
+ base::UTF16ToASCII(display_origin_));
+ }
ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
bool show_persistence_toggle = true;

Powered by Google App Engine
This is Rietveld 408576698