Allow gen_file_type_proto.py to work in virtualenv.

Allow gen_file_type_proto.py to work in virtualenv.

There were complaints in crbug.com/605592 that virtualenv builds
are broken with the strategy of passing -w to gen_file_type_proto.py.
Systems can use virtualenv to isolate the Python environment from
dist-packages, making the nested call to this script redundant (and
broken, since -S breaks some assumptions from virtualenv).

BUG=605592
BUG=614082
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a0c75183f6dab0b8ab2953b34595d6fd5651b9bc
Cr-Commit-Position: refs/heads/master@{#428777}

[sanfin, 2016-09-17 02:24:20]

Description was changed from

==========
Allow gen_file_type_proto.py to work in virtualenv.

There were complaints in crbug.com/605592 that virtualenv builds
are broken with the strategy of passing -w to gen_file_type_proto.py.
Systems can use virtualenv to isolate the Python environment from
dist-packages, making the nested call to this script redundant (and
broken, since -S breaks some assumptions from virtualenv).

BUG=605592
BUG=614082
==========

to

==========
Allow gen_file_type_proto.py to work in virtualenv.

There were complaints in crbug.com/605592 that virtualenv builds
are broken with the strategy of passing -w to gen_file_type_proto.py.
Systems can use virtualenv to isolate the Python environment from
dist-packages, making the nested call to this script redundant (and
broken, since -S breaks some assumptions from virtualenv).

BUG=605592
BUG=614082
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Simeon, 2016-09-17 02:28:33]

sanfin@chromium.org changed reviewers:
+ mbjorge@chromium.org, nparker@chromium.org, sanfin@chromium.org,
slan@chromium.org, xyzzyz@chromium.org

[Simeon, 2016-09-17 02:28:34]

Hi all,

The Chromecast buildbots use a Python virtualenv to build our targets, which
breaks when we have the -S flag passed to the Python interpreter, as in
gen_file_type_proto.py. This change allows the script to function on virtualenv
environments and non-virtual environments alike, without requiring us to have a
local patch in internal Chromecast code to comment out the -w parameter in the
gn target.

PTAL

[xyzzyz, 2016-09-19 14:02:14]

lgtm, but please be sure to run it on all trybots, as this kind of changes tend
to break setups different than the one author tests it on (the "-s -S" change
was originally introduced to work around an issue with gentoo, where this script
attempted to use the protobuf library shipped with gentoo instead of chromium's
one).

https://codereview.chromium.org/2341173004/diff/1/chrome/browser/resources/sa...
File chrome/browser/resources/safe_browsing/gen_file_type_proto.py (right):

https://codereview.chromium.org/2341173004/diff/1/chrome/browser/resources/sa...
chrome/browser/resources/safe_browsing/gen_file_type_proto.py:22: return
hasattr(sys, 'real_prefix')
Is it an official way of detecting being run inside a virtualenv?

[mbjorge, 2016-09-19 15:25:37]

https://codereview.chromium.org/2341173004/diff/1/chrome/browser/resources/sa...
File chrome/browser/resources/safe_browsing/gen_file_type_proto.py (right):

https://codereview.chromium.org/2341173004/diff/1/chrome/browser/resources/sa...
chrome/browser/resources/safe_browsing/gen_file_type_proto.py:22: return
hasattr(sys, 'real_prefix')
On 2016/09/19 at 14:02:14, xyzzyz wrote:
> Is it an official way of detecting being run inside a virtualenv?

It's not official; pip uses this method also though, so that may give it some
credence:
https://github.com/pypa/pip/blob/281eb61b09d87765d7c2b92f6982b3fe76ccb0af/pip...

[Nathan Parker, 2016-09-19 16:46:23]

https://codereview.chromium.org/2341173004/diff/1/chrome/browser/resources/sa...
File chrome/browser/resources/safe_browsing/gen_file_type_proto.py (right):

https://codereview.chromium.org/2341173004/diff/1/chrome/browser/resources/sa...
chrome/browser/resources/safe_browsing/gen_file_type_proto.py:21: def
IsInVirtualEnv():
Add some comments describing why this is here, or what environment actually
triggers it.

Looks like the assumption is that if IsInVirtualEnv(), then the paths for proto
modules are already correct.

[Simeon, 2016-09-21 23:22:07]

The CQ bit was checked by sanfin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 23:22:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:22:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 23:22:55]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Simeon, 2016-09-22 22:17:50]

https://codereview.chromium.org/2341173004/diff/1/chrome/browser/resources/sa...
File chrome/browser/resources/safe_browsing/gen_file_type_proto.py (right):

https://codereview.chromium.org/2341173004/diff/1/chrome/browser/resources/sa...
chrome/browser/resources/safe_browsing/gen_file_type_proto.py:21: def
IsInVirtualEnv():
On 2016/09/19 16:46:23, Nathan Parker wrote:
> Add some comments describing why this is here, or what environment actually
> triggers it.
> 
> Looks like the assumption is that if IsInVirtualEnv(), then the paths for
proto
> modules are already correct.

Done.

[Simeon, 2016-09-28 17:38:09]

The CQ bit was checked by sanfin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 17:39:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 17:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 17:39:03]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Nathan Parker, 2016-10-21 04:02:38]

lgtm

[Simeon, 2016-10-24 22:45:51]

The CQ bit was checked by sanfin@chromium.org

[Simeon, 2016-10-24 22:45:52]

The patchset sent to the CQ was uploaded after l-g-t-m from xyzzyz@chromium.org
Link to the patchset: https://codereview.chromium.org/2341173004/#ps20001
(title: "Added comments")

[commit-bot: I haz the power, 2016-10-24 22:46:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:56:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:56:21]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Simeon, 2016-10-24 23:00:14]

The CQ bit was checked by sanfin@chromium.org

[commit-bot: I haz the power, 2016-10-24 23:01:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 23:15:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 23:15:39]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Simeon, 2016-10-31 18:40:15]

The CQ bit was checked by sanfin@chromium.org

[commit-bot: I haz the power, 2016-10-31 18:40:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 20:03:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-31 20:05:44]

Description was changed from

==========
Allow gen_file_type_proto.py to work in virtualenv.

There were complaints in crbug.com/605592 that virtualenv builds
are broken with the strategy of passing -w to gen_file_type_proto.py.
Systems can use virtualenv to isolate the Python environment from
dist-packages, making the nested call to this script redundant (and
broken, since -S breaks some assumptions from virtualenv).

BUG=605592
BUG=614082
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Allow gen_file_type_proto.py to work in virtualenv.

There were complaints in crbug.com/605592 that virtualenv builds
are broken with the strategy of passing -w to gen_file_type_proto.py.
Systems can use virtualenv to isolate the Python environment from
dist-packages, making the nested call to this script redundant (and
broken, since -S breaks some assumptions from virtualenv).

BUG=605592
BUG=614082
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a0c75183f6dab0b8ab2953b34595d6fd5651b9bc
Cr-Commit-Position: refs/heads/master@{#428777}
==========

[commit-bot: I haz the power, 2016-10-31 20:05:45]

Patchset 2 (id:??) landed as
https://crrev.com/a0c75183f6dab0b8ab2953b34595d6fd5651b9bc
Cr-Commit-Position: refs/heads/master@{#428777}