Make symlink.py always updates the symlink timestamp

Make symlink.py always updates the symlink timestamp

This will (hopefully) make ninja realize that the file is not stale.
This also removes an unused arg from symlink.gni

BUG=646165

[agrieve, 2016-09-15 20:34:22]

Description was changed from

==========
Make symlink.py always updates the symlink timestamp

This will (hopefully) make ninja realize that the file is not stale.

BUG=646165
==========

to

==========
Make symlink.py always updates the symlink timestamp

This will (hopefully) make ninja realize that the file is not stale.
This also removes an unused arg from symlink.gni

BUG=646165
==========

[agrieve, 2016-09-15 20:34:22]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org

[agrieve, 2016-09-15 20:34:26]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 20:35:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-09-15 20:36:05]

On 2016/09/15 20:34:26, agrieve wrote:
> The CQ bit was checked by mailto:agrieve@chromium.org to run a CQ dry run

Note: Still unsure why the error messages were complaining of a 0 timestamp.
e.g.:
ninja: Entering directory
`/b/build/slave/Android_Cronet_MIPS_Builder/build/src/out/Release'
ninja explain: restat of output host_forwarder older than most recent input
obj/tools/android/forwarder2/host_forwarder.inputdeps.stamp (0 vs 1473965302)
ninja explain: host_forwarder is dirty
[1/2] ACTION
//tools/android/forwarder2:host_forwarder(//build/toolchain/android:mipsel)

Also haven't tested that this fixes the problem, but certainly seems like it's
got a shot :P

[agrieve, 2016-09-15 20:36:47]

On 2016/09/15 20:36:05, agrieve wrote:
> On 2016/09/15 20:34:26, agrieve wrote:
> > The CQ bit was checked by mailto:agrieve@chromium.org to run a CQ dry run
> 
> Note: Still unsure why the error messages were complaining of a 0 timestamp.
> e.g.:
> ninja: Entering directory
> `/b/build/slave/Android_Cronet_MIPS_Builder/build/src/out/Release'
> ninja explain: restat of output host_forwarder older than most recent input
> obj/tools/android/forwarder2/host_forwarder.inputdeps.stamp (0 vs 1473965302)
> ninja explain: host_forwarder is dirty
> [1/2] ACTION
> //tools/android/forwarder2:host_forwarder(//build/toolchain/android:mipsel)
> 
> Also haven't tested that this fixes the problem, but certainly seems like it's
> got a shot :P

Actually, I know how I can test this theory out, so will make sure to do so
before re-re-relanding the recipe to enable the check.

[Dirk Pranke, 2016-09-15 20:53:12]

lgtm

[commit-bot: I haz the power, 2016-09-15 21:44:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:44:49]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-09-16 01:37:23]

On 2016/09/15 20:53:12, Dirk Pranke wrote:
> lgtm

Not going to go ahead with this one. I've determined the actually problem is
that ninja is following the symlink when checking mtimes
(https://github.com/ninja-build/ninja/issues/1186).