Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2341103002: presubmit_support: Remove a noisy logging.debug() (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

presubmit_support: Remove a noisy logging.debug() On a CL with a single file, presubmit writes all this noise: Running /b/build/slave/linux/build/src/PRESUBMIT.py DEBUG:root:Running CheckChangeOnCommit in /b/build/slave/linux/build/src/PRESUBMIT.py DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:git diff -p --no-color --no-prefix --no-ext-diff 691e0c7d46341465de7a605b5f2aee941ccfedc0...HEAD --no-renames; cwd=/b/build/slave/linux/build/src DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:/usr/bin/python /b/build/slave/linux/build/src/tools/checkperms/checkperms.py --root /b/build/slave/linux/build/src --file content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:^(android_webview|base|content|net)[\\\/].* matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:LocalPaths: ['content/browser/gpu/gpu_data_manager_impl_private.cc'] DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc DEBUG:root:Running CheckChangeOnCommit done. The "a matched b" lines are boring and numerous, so remove this log line. If we ever need it to debug something, we can add it back then (temporarily). (From https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/260304/steps/presubmit/logs/stdio) BUG=none Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/adcd4b78d5f35da535ccf82a221afb9fa389f631

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M presubmit_support.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
Nico
4 years, 3 months ago (2016-09-15 18:03:17 UTC) #4
M-A Ruel
lgtm
4 years, 3 months ago (2016-09-15 20:55:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341103002/20001
4 years, 3 months ago (2016-09-15 21:12:40 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 21:15:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/adcd4b78d5f35d...

Powered by Google App Engine
This is Rietveld 408576698