Mark the createVisiblePosition overloads as deprecated

third_party/WebKit/Source/core/editing/VisiblePosition.h

 /*
  * Copyright (C) 2004, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 53 matching lines @@
 //    |def  DOWNSTREAM |VisiblePosition|
 //
 // NOTE: UPSTREAM affinity will be used only if pos is at end of a wrapped line,
 // otherwise it will be converted to DOWNSTREAM.
 template <typename Strategy>
 class CORE_TEMPLATE_CLASS_EXPORT VisiblePositionTemplate final {
     DISALLOW_NEW();
 public:
     VisiblePositionTemplate();
 
-    // Node: Other than |createVisiblePosition()|, we should not use
-    // |create()|.
+    // Node: Other than |createVisiblePosition()| and
+    // |createVisiblePositionDeprecated()|, we should not use |create()|.
     static VisiblePositionTemplate create(const PositionWithAffinityTemplate<Strategy>&);
 
     // Intentionally delete |operator==()| and |operator!=()| for reducing
     // compilation error message.
     // TODO(yosin) We'll have |equals()| when we have use cases of checking
     // equality of both position and affinity.
     bool operator==(const VisiblePositionTemplate&) const = delete;
     bool operator!=(const VisiblePositionTemplate&) const = delete;
 
     bool isNull() const { return m_positionWithAffinity.isNull(); }
@@ skipping 26 matching lines @@
 
     PositionWithAffinityTemplate<Strategy> m_positionWithAffinity;
 };
 
 extern template class CORE_EXTERN_TEMPLATE_EXPORT VisiblePositionTemplate<EditingStrategy>;
 extern template class CORE_EXTERN_TEMPLATE_EXPORT VisiblePositionTemplate<EditingInFlatTreeStrategy>;
 
 using VisiblePosition = VisiblePositionTemplate<EditingStrategy>;
 using VisiblePositionInFlatTree = VisiblePositionTemplate<EditingInFlatTreeStrategy>;
 
+// |createVisiblePositionDeprecated| updates layout before creating the
+// VisiblePosition, which messes up the rendering pipeline. The callers should
+// ensure clean layout by themselves and call |createVisiblePosition| instead.
+CORE_EXPORT VisiblePosition createVisiblePositionDeprecated(const Position&, TextAffinity = VP_DEFAULT_AFFINITY);
+CORE_EXPORT VisiblePosition createVisiblePositionDeprecated(const PositionWithAffinity&);
+CORE_EXPORT VisiblePositionInFlatTree createVisiblePositionDeprecated(const PositionInFlatTree&, TextAffinity = VP_DEFAULT_AFFINITY);
+CORE_EXPORT VisiblePositionInFlatTree createVisiblePositionDeprecated(const PositionInFlatTreeWithAffinity&);
+
 CORE_EXPORT VisiblePosition createVisiblePosition(const Position&, TextAffinity = VP_DEFAULT_AFFINITY);
 CORE_EXPORT VisiblePosition createVisiblePosition(const PositionWithAffinity&);
 CORE_EXPORT VisiblePositionInFlatTree createVisiblePosition(const PositionInFlatTree&, TextAffinity = VP_DEFAULT_AFFINITY);
 CORE_EXPORT VisiblePositionInFlatTree createVisiblePosition(const PositionInFlatTreeWithAffinity&);
 
 CORE_EXPORT std::ostream& operator<<(std::ostream&, const VisiblePosition&);
 CORE_EXPORT std::ostream& operator<<(std::ostream&, const VisiblePositionInFlatTree&);
 
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showTree(const blink::VisiblePosition*);
 void showTree(const blink::VisiblePosition&);
 #endif
 
 #endif // VisiblePosition_h