Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2341043003: Update version of SVG asset (Closed)

Created:
4 years, 3 months ago by rmistry
Modified:
4 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org, jcgregorio
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : Initial upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M infra/bots/assets/svg/VERSION View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
rmistry
4 years, 3 months ago (2016-09-15 16:46:31 UTC) #3
borenet
Rubber stamp LGTM
4 years, 3 months ago (2016-09-15 17:19:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341043003/1
4 years, 3 months ago (2016-09-15 17:49:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ab00f4222c9fff8c08873e1218e79f49845f95a1
4 years, 3 months ago (2016-09-15 18:31:28 UTC) #8
djsollen
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2337763007/ by djsollen@google.com. ...
4 years, 3 months ago (2016-09-15 20:04:25 UTC) #9
f(malita)
On 2016/09/15 20:04:25, djsollen wrote: > A revert of this CL (patchset #1 id:1) has ...
4 years, 3 months ago (2016-09-15 23:40:55 UTC) #10
rmistry
On 2016/09/15 23:40:55, f(malita) wrote: > On 2016/09/15 20:04:25, djsollen wrote: > > A revert ...
4 years, 3 months ago (2016-09-16 12:16:28 UTC) #11
rmistry
4 years, 3 months ago (2016-09-16 12:16:30 UTC) #12
Message was sent while issue was closed.
On 2016/09/15 23:40:55, f(malita) wrote:
> On 2016/09/15 20:04:25, djsollen wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/2337763007/ by mailto:djsollen@google.com.
> > 
> > The reason for reverting is: breaking the build.
> 
> parse error @1:0: 2 (syntax error).
> xml parse error, line -1
> 
> 
> FAILURE: 8888 svg  Seal_of_Mississippi_2014.svg: Unable to parse file:
> c:\b\swarm_slave\w\irm0wbyl\svg\Seal_of_Mississippi_2014.svg
> 
> ^ this is pretty weird:
> 
> 1) Seal_of_Mississippi_2014.svg is not part of the new batch, it has been in
the
> old corpus for a while
> 
> 2) it parses/renders just fine locally
> 
> 3) that error is low-level/XML, coming from Expat
> 
> My only guess is this file got corrupted somehow.  I'll check with Ravi
> tomorrow.

Filed https://bugs.chromium.org/p/skia/issues/detail?id=5767

Powered by Google App Engine
This is Rietveld 408576698