Fix issue 12718 - crash when the trying to access context variables in a frame.

runtime/vm/debugger.cc

Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc	(revision 26534)
+++ runtime/vm/debugger.cc	(working copy)
@@ -535,17 +535,24 @@
     intptr_t level_diff = frame_ctx_level - var_ctx_level;
     intptr_t ctx_slot = var_info.index;
     if (level_diff == 0) {
-      *value = ctx_.At(ctx_slot);
+      if ((ctx_slot < ctx_.num_variables()) && (ctx_slot >= 0)) {
+        *value = ctx_.At(ctx_slot);
+      } else {

[hausner, 2013/08/26 15:27:48]

Maybe add a comment here describing that we only get here if something is wrong
and we have the wrong context. TODO: fix context restoration in stack trace
collection code.

[siva, 2013/08/26 16:55:39]

Created an issue https://code.google.com/p/dart/issues/detail?id=12767 and added
a TODO (12767) here.

On 2013/08/26 15:27:48, hausner wrote:

+        *value = Symbols::New("<unknown>");
+      }
     } else {
       ASSERT(level_diff > 0);
       Context& ctx = Context::Handle(ctx_.raw());
-      while (level_diff > 0) {
-        ASSERT(!ctx.IsNull());
+      while (level_diff > 0 && !ctx.IsNull()) {
         level_diff--;
         ctx = ctx.parent();
       }
-      ASSERT(!ctx.IsNull());
-      *value = ctx.At(ctx_slot);
+      if (!ctx.IsNull() &&
+          ((ctx_slot < ctx_.num_variables()) && (ctx_slot >= 0))) {
+        *value = ctx.At(ctx_slot);
+      } else {
+        *value = Symbols::New("<unknown>");

[hausner, 2013/08/26 15:27:48]

ditto.

[siva, 2013/08/26 16:55:39]

Ditto.

On 2013/08/26 15:27:48, hausner wrote:

+      }
     }
   }
 }