Remove unnecessary boolean from CSPDirectiveList

Remove unnecessary boolean from CSPDirectiveList

We had a boolean that replicated the meaning of m_headerType so all instance of the former were changed in favor of using isReportOnly class method.

R=mkwst@chromium.org

Committed: https://crrev.com/abe073d91e7d1f684f7086e3675b57d624457813
Cr-Commit-Position: refs/heads/master@{#419146}

[amalika, 2016-09-16 10:00:04]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 10:00:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amalika, 2016-09-16 10:02:45]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 10:03:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amalika, 2016-09-16 10:05:58]

Patchset #1 (id:1) has been deleted

[Mike West, 2016-09-16 10:08:43]

LGTM, if you change the code to use the shortcut `isReportOnly()`, since it's a
lot easier to read than checking a comparison between `m_headerType` and an enum
value.

https://codereview.chromium.org/2340983004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp (right):

https://codereview.chromium.org/2340983004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp:79: String message
= (m_headerType == ContentSecurityPolicyHeaderTypeReport) ? "[Report Only] " +
consoleMessage : consoleMessage;
Nit: Ditto.

https://codereview.chromium.org/2340983004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h (right):

https://codereview.chromium.org/2340983004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h:80: bool
isFrameAncestorsEnforced() const { return m_frameAncestors.get() && m_headerType
!= ContentSecurityPolicyHeaderTypeReport; }
Nit: This is probably simpler to spell as `!isReportOnly()`.

https://codereview.chromium.org/2340983004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h:145: bool
denyIfEnforcingPolicy() const { return m_headerType ==
ContentSecurityPolicyHeaderTypeReport; }
Nit: Ditto.

[amalika, 2016-09-16 11:07:21]

Patchset #2 (id:40001) has been deleted

[Mike West, 2016-09-16 11:13:39]

https://codereview.chromium.org/2340983004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h (right):

https://codereview.chromium.org/2340983004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h:145: bool
denyIfEnforcingPolicy() const { return m_headerType ==
ContentSecurityPolicyHeaderTypeReport; }
Nit: Here too.

[amalika, 2016-09-16 11:18:21]

The CQ bit was checked by amalika@google.com

[amalika, 2016-09-16 11:18:22]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2340983004/#ps80001
(title: "Updating the denyIfgPolicy")

[commit-bot: I haz the power, 2016-09-16 11:18:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amalika, 2016-09-16 11:18:51]

Description was changed from

==========
Remove unnecessary boolean from CSPDirectiveList

We had a boolean that replicated the meaning of m_headerType so all instance of
the former were changed in favor of comparing the exisiting m_headerType.

R=mkwst@chromium.org
==========

to

==========
Remove unnecessary boolean from CSPDirectiveList

We had a boolean that replicated the meaning of m_headerType so all instance of
the former were changed in favor of using isReportOnly class method.

R=mkwst@chromium.org
==========

[commit-bot: I haz the power, 2016-09-16 12:31:07]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-09-16 12:32:58]

Description was changed from

==========
Remove unnecessary boolean from CSPDirectiveList

We had a boolean that replicated the meaning of m_headerType so all instance of
the former were changed in favor of using isReportOnly class method.

R=mkwst@chromium.org
==========

to

==========
Remove unnecessary boolean from CSPDirectiveList

We had a boolean that replicated the meaning of m_headerType so all instance of
the former were changed in favor of using isReportOnly class method.

R=mkwst@chromium.org

Committed: https://crrev.com/abe073d91e7d1f684f7086e3675b57d624457813
Cr-Commit-Position: refs/heads/master@{#419146}
==========

[commit-bot: I haz the power, 2016-09-16 12:33:00]

Patchset 3 (id:??) landed as
https://crrev.com/abe073d91e7d1f684f7086e3675b57d624457813
Cr-Commit-Position: refs/heads/master@{#419146}