Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2340973002: Improve VM connection flow in Observatory (Closed)

Created:
4 years, 3 months ago by Cutch
Modified:
4 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, rmacnak
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve VM connection flow in Observatory - [x] Don't show "(Connected)" next to a VM we aren't connected to. - [x] Navigate to the vm-connect page if we get an initial connection error. - [x] Fix regression of the 'vm disconnected' notification bubble not appearing. - [x] Use the Uris helper class instead of hard coded paths - [x] Improve user inputted URI normalization - [x] Ignore network errors on stream subscription requests - [x] On first launch, attempt to connect to the default target and not the last target connected to. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/72b79d970baa8a2cea93e0cb3b0e2d50fc17d473

Patch Set 1 #

Patch Set 2 : Improve VM connection flow in Observatory #

Patch Set 3 : Improve VM connection flow in Observatory #

Patch Set 4 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -65 lines) Patch
M runtime/observatory/lib/app.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/service_common.dart View 1 2 3 7 chunks +19 lines, -11 lines 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 1 2 3 chunks +70 lines, -24 lines 0 comments Download
M runtime/observatory/lib/src/app/location_manager.dart View 1 2 4 chunks +3 lines, -13 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 chunks +7 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.dart View 1 2 3 3 chunks +17 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/repositories/isolate.dart View 1 1 chunk +5 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/target.dart View 1 2 3 chunks +17 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 8 chunks +28 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Cutch
PTAL
4 years, 3 months ago (2016-09-15 17:24:35 UTC) #4
rmacnak
lgtm Just noting some remaining issues: - I've seen some invalid vm addresses listed, like ...
4 years, 3 months ago (2016-09-15 17:55:57 UTC) #5
Cutch
The weird addresses are stale state that you'll have to remove manually. I've fixed the ...
4 years, 3 months ago (2016-09-15 18:17:36 UTC) #7
Cutch
4 years, 3 months ago (2016-09-15 18:29:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
72b79d970baa8a2cea93e0cb3b0e2d50fc17d473 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698