Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 2340953002: Reland of "[modules] Make duplicate export error deterministic." (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "[modules] Make duplicate export error deterministic." In case of duplicate exports, always report the error for the very last one. (Fixed a bug.) BUG=v8:5358, v8:1569 Committed: https://crrev.com/d383430d932f0eb7d8e832feeb9b60f5666f31de Cr-Commit-Position: refs/heads/master@{#39434}

Patch Set 1 #

Patch Set 2 : The bug fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -19 lines) Patch
M src/ast/modules.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast/modules.cc View 1 1 chunk +27 lines, -6 lines 0 comments Download
M test/message/export-duplicate.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/message/export-duplicate.out View 1 chunk +3 lines, -3 lines 0 comments Download
M test/message/export-duplicate-as.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/message/export-duplicate-as.out View 1 chunk +2 lines, -2 lines 0 comments Download
M test/message/export-duplicate-default.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/message/export-duplicate-default.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/message.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
neis
PTAL
4 years, 3 months ago (2016-09-15 01:05:40 UTC) #4
adamk
lgtm
4 years, 3 months ago (2016-09-15 01:08:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340953002/20001
4 years, 3 months ago (2016-09-15 01:09:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 01:36:20 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 01:37:15 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d383430d932f0eb7d8e832feeb9b60f5666f31de
Cr-Commit-Position: refs/heads/master@{#39434}

Powered by Google App Engine
This is Rietveld 408576698