Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 2340933004: Do not try to enroll past OOBE/enrollment. (Closed)

Created:
4 years, 3 months ago by The one and only Dr. Crash
Modified:
4 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not try to enroll past OOBE/enrollment. BUG=647480 TEST=manual Committed: https://crrev.com/ebafc22b74ceef8bb436396bf3194b8759c48a59 Cr-Commit-Position: refs/heads/master@{#419302}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Forgot unit tests. (Oops.) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_initializer_unittest.cc View 1 5 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
The one and only Dr. Crash
4 years, 3 months ago (2016-09-16 00:03:55 UTC) #2
The one and only Dr. Crash
On 2016/09/16 00:03:55, The one and only Dr. Crash wrote: This ensures that EnrollmentConfig::should_enroll() won't ...
4 years, 3 months ago (2016-09-16 06:32:33 UTC) #3
xiyuan
lgtm https://codereview.chromium.org/2340933004/diff/1/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc File chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc (right): https://codereview.chromium.org/2340933004/diff/1/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc#newcode157 chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc:157: config.auth_mechanism = EnrollmentConfig::AUTH_MECHANISM_INTERACTIVE; nit: wrap with {} since ...
4 years, 3 months ago (2016-09-16 07:49:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340933004/1
4 years, 3 months ago (2016-09-16 17:28:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/237011)
4 years, 3 months ago (2016-09-16 18:06:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340933004/20001
4 years, 3 months ago (2016-09-16 21:07:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 22:29:08 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 22:32:32 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ebafc22b74ceef8bb436396bf3194b8759c48a59
Cr-Commit-Position: refs/heads/master@{#419302}

Powered by Google App Engine
This is Rietveld 408576698