Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2340923003: CC Animation: Rework iterations over players to use the range-based for loop. (Closed)

Created:
4 years, 3 months ago by loyso (OOO)
Modified:
4 years, 2 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, alancutter (OOO until 2018), ymalik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Rework iterations over players to use the range-based for loop. BUG=634916 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/b5e01c1bf59099c9433780c65fddb8786b97164c Cr-Commit-Position: refs/heads/master@{#424626}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Use iterator deref instead of GetCurrent (affected by base CL) #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -155 lines) Patch
M cc/animation/animation_player.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M cc/animation/element_animations.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M cc/animation/element_animations.cc View 1 2 3 4 19 chunks +61 lines, -119 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 1 2 3 4 2 chunks +4 lines, -9 lines 0 comments Download
M cc/test/animation_test_common.cc View 1 2 3 4 3 chunks +3 lines, -9 lines 0 comments Download
M cc/test/animation_timelines_test_common.cc View 1 2 3 4 1 chunk +4 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 34 (27 generated)
loyso (OOO)
4 years, 3 months ago (2016-09-15 08:00:53 UTC) #6
loyso (OOO)
Do not review please - to be fixed.
4 years, 3 months ago (2016-09-15 08:08:10 UTC) #7
loyso (OOO)
PTAL! It's ready to be landed.
4 years, 3 months ago (2016-09-16 03:11:20 UTC) #14
ajuma
This is much nicer, lgtm!
4 years, 3 months ago (2016-09-16 14:03:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340923003/100001
4 years, 2 months ago (2016-10-11 23:36:24 UTC) #30
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-10-12 01:11:17 UTC) #32
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 01:18:13 UTC) #34
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/b5e01c1bf59099c9433780c65fddb8786b97164c
Cr-Commit-Position: refs/heads/master@{#424626}

Powered by Google App Engine
This is Rietveld 408576698