Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2340893002: Re-land: Add fuzzer for AXTree and fix a couple of bugs it found. (Closed)

Created:
4 years, 3 months ago by dmazzoni
Modified:
4 years, 3 months ago
Reviewers:
mmoroz, aboxhall
CC:
aboxhall+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, fuzzing_chromium.org, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Add fuzzer for AXTree and fix a couple of bugs it found. Original change: https://codereview.chromium.org/2323103002/ Fix: On Android, the delegate callback called in DestroySubtree was accessing AXTree::root() after we had deleted it but before we set it to null. We need to clear it first and then destroy it. BUG=646777 TBR=aboxhall,mmoroz Committed: https://crrev.com/5cc41399cda7791ea8edba552304f525b280cfb6 Cr-Commit-Position: refs/heads/master@{#418698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -3 lines) Patch
M ui/accessibility/BUILD.gn View 2 chunks +11 lines, -0 lines 0 comments Download
M ui/accessibility/ax_tree.cc View 2 chunks +11 lines, -3 lines 0 comments Download
A ui/accessibility/ax_tree_fuzzer.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M ui/accessibility/ax_tree_unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dmazzoni
4 years, 3 months ago (2016-09-14 21:00:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340893002/1
4 years, 3 months ago (2016-09-14 21:00:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 22:33:46 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5cc41399cda7791ea8edba552304f525b280cfb6 Cr-Commit-Position: refs/heads/master@{#418698}
4 years, 3 months ago (2016-09-14 22:35:47 UTC) #8
mmoroz
4 years, 3 months ago (2016-09-15 14:01:31 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698