third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp - Issue 2340883003: Treat null dictionary members as missing per WebIDL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp

Issue 2340883003: Treat null dictionary members as missing per WebIDL (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp

index 07e64be46a30f9ea981e3ece10597829081a8a2b..c3df0c619c022c8d9b5a0fdc6b364d9bf6728615 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp

@@ -36,7 +36,7 @@ void V8TestInterfaceEventInit::toImpl(v8::Isolate* isolate, v8::Local<v8::Value>

exceptionState.rethrowV8Exception(block.Exception());

return;

}

- if (stringMemberValue.IsEmpty() || stringMemberValue->IsUndefined()) {

+ if (isUndefinedOrNull(stringMemberValue)) {

// Do nothing.

} else {

V8StringResource<> stringMember = stringMemberValue;