Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2340883002: Observatory: Fix allocation profile CVS export. Fix heap snapshot in/out reference counts. (Closed)

Created:
4 years, 3 months ago by rmacnak
Modified:
4 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Observatory: Fix allocation profile CSV export. Fix heap snapshot in/out reference counts. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/cd4c9fc46b51b05f4e4d089730027bd13ed65bcd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M runtime/observatory/lib/src/elements/allocation_profile.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.dart View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 3 months ago (2016-09-14 20:40:14 UTC) #2
Cutch
lgtm
4 years, 3 months ago (2016-09-14 22:20:13 UTC) #3
rmacnak
4 years, 3 months ago (2016-09-14 22:44:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd4c9fc46b51b05f4e4d089730027bd13ed65bcd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698