ios/chrome/browser/open_url_util.h - Issue 2340873002: Creates open_url_util files

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/open_url_util.h

Issue 2340873002: Creates open_url_util files (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_OPEN_URL_UTIL_H_

	6 #define IOS_CHROME_BROWSER_OPEN_URL_UTIL_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 // Wrapper method for UIApplication openURL() that uses

	11 // the non-deprecated method when it is available (iOS10+).

	12 void OpenURLWithCompletionHandler(NSURL* url,
	Eugene But (OOO till 7-30) 2016/09/14 20:20:07 Per comment in downstream CL: s/OpenURLWithComple Per comment in downstream CL: s/OpenURLWithCompletionHandler/OpenUrlWithCompletionHandler According to C++ Style Guide we should use Url case for acronyms. We should all all caps URL for Objective-C names only. sczs 2016/09/15 20:35:47 Done. Show quoted text On 2016/09/14 20:20:07, Eugene But wrote: > Per comment in downstream CL: > > s/OpenURLWithCompletionHandler/OpenUrlWithCompletionHandler > > According to C++ Style Guide we should use Url case for acronyms. We should all > all caps URL for Objective-C names only. Done.
	13 void (^completion_handler)(BOOL success));

	14

	15 #endif // IOS_CHROME_BROWSER_OPEN_URL_UTIL_H_

OLD	NEW