Fix the crash: Failed to create WebAPKServiceImpl.

Fix the crash: Failed to create WebAPKServiceImpl.

The crash is caused by not including the AIDL files from which the
WebApkServiceImpl is inherited in the webapk1.dex. In the build.gn, I move the
dependency of webapk_service_aidl from "deps" to "srcjar_deps", since the
.java files in the latter will be included in webapk1.dex.

BUG=645215
Committed: https://crrev.com/9ad9ad873f501e8c119fe02267a788add0775426
Cr-Commit-Position: refs/heads/master@{#419017}

[Xi Han, 2016-09-14 19:20:47]

hanxi@chromium.org changed reviewers:
+ agrieve@chromium.org

[Xi Han, 2016-09-14 19:20:48]

Hi Andrew, could you please take a look? Thanks!

[agrieve, 2016-09-14 19:31:35]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[agrieve, 2016-09-14 19:32:10]

On 2016/09/14 19:20:48, Xi Han wrote:
> Hi Andrew, could you please take a look? Thanks!

Hmm, I think there was a reason Sam found that this needed to be changed to a
library. Let's see how the bots do.

[commit-bot: I haz the power, 2016-09-14 19:32:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-09-14 19:34:57]

That said, I think this makes sense, so lgtm if the bots are happy.

[Xi Han, 2016-09-14 19:45:59]

On 2016/09/14 19:34:57, agrieve wrote:
> That said, I think this makes sense, so lgtm if the bots are happy.

Thanks Andrew, I will wait for the dry-run results:)

[commit-bot: I haz the power, 2016-09-14 21:40:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 21:40:17]

Dry run: This issue passed the CQ dry run.

[Xi Han, 2016-09-15 13:45:51]

Description was changed from

==========
Fix the crash: Failed to create WebAPKServiceImpl.

The crash is caused by not including the AIDL files from which the
WebApkServiceImpl is inherited in the webapk1.dex. In the build.gn, I move the
dependency of webapk_service_aidl from "deps" to "srcjar_deps", since the
.java files in the latter will be included in webapk1.dex.

BUG=645215
==========

to

==========
Fix the crash: Failed to create WebAPKServiceImpl.

The crash is caused by not including the AIDL files from which the
WebApkServiceImpl is inherited in the webapk1.dex. In the build.gn, I move the
dependency of webapk_service_aidl from "deps" to "srcjar_deps", since the
.java files in the latter will be included in webapk1.dex.

BUG=645215
==========

[Xi Han, 2016-09-15 13:45:51]

hanxi@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[Xi Han, 2016-09-15 13:46:23]

+pkotwicz@, please take a look, thanks!

[pkotwicz, 2016-09-15 19:37:34]

LGTM

[Xi Han, 2016-09-15 19:43:20]

The CQ bit was checked by hanxi@chromium.org

[commit-bot: I haz the power, 2016-09-15 19:44:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 22:35:57]

Description was changed from

==========
Fix the crash: Failed to create WebAPKServiceImpl.

The crash is caused by not including the AIDL files from which the
WebApkServiceImpl is inherited in the webapk1.dex. In the build.gn, I move the
dependency of webapk_service_aidl from "deps" to "srcjar_deps", since the
.java files in the latter will be included in webapk1.dex.

BUG=645215
==========

to

==========
Fix the crash: Failed to create WebAPKServiceImpl.

The crash is caused by not including the AIDL files from which the
WebApkServiceImpl is inherited in the webapk1.dex. In the build.gn, I move the
dependency of webapk_service_aidl from "deps" to "srcjar_deps", since the
.java files in the latter will be included in webapk1.dex.

BUG=645215
==========

[commit-bot: I haz the power, 2016-09-15 22:35:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-15 22:37:33]

Description was changed from

==========
Fix the crash: Failed to create WebAPKServiceImpl.

The crash is caused by not including the AIDL files from which the
WebApkServiceImpl is inherited in the webapk1.dex. In the build.gn, I move the
dependency of webapk_service_aidl from "deps" to "srcjar_deps", since the
.java files in the latter will be included in webapk1.dex.

BUG=645215
==========

to

==========
Fix the crash: Failed to create WebAPKServiceImpl.

The crash is caused by not including the AIDL files from which the
WebApkServiceImpl is inherited in the webapk1.dex. In the build.gn, I move the
dependency of webapk_service_aidl from "deps" to "srcjar_deps", since the
.java files in the latter will be included in webapk1.dex.

BUG=645215

Committed: https://crrev.com/9ad9ad873f501e8c119fe02267a788add0775426
Cr-Commit-Position: refs/heads/master@{#419017}
==========

[commit-bot: I haz the power, 2016-09-15 22:37:33]

Patchset 1 (id:??) landed as
https://crrev.com/9ad9ad873f501e8c119fe02267a788add0775426
Cr-Commit-Position: refs/heads/master@{#419017}