Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2340823002: Turn on more of the platform_canvas_unittests (Closed)

Created:
4 years, 3 months ago by tomhudson
Modified:
4 years, 3 months ago
Reviewers:
f(malita)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on more of the platform_canvas_unittests Most of the TranslateLayer test can pass even on AURA machines; only one clause needs to be #ifdef'd out on MACOS *and* AURA. Also documents the surpising DstATop xfermode use in MakeOpaque, and changes that function from OS_WIN-only to running on every platform, where it should be a cheap noop. Followup: other parts of the Chrome codebase have their own MakeOpaque implementations; we can probably share this through skia_utils. R=fmalita@chromium.org BUG=154358 Committed: https://crrev.com/b3a7f2e02a2a56063ee148bec097002e8c812598 Cr-Commit-Position: refs/heads/master@{#418607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -25 lines) Patch
M skia/ext/platform_canvas_unittest.cc View 13 chunks +7 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tomhudson
PTAL
4 years, 3 months ago (2016-09-14 16:29:09 UTC) #2
f(malita)
lgtm
4 years, 3 months ago (2016-09-14 17:04:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340823002/1
4 years, 3 months ago (2016-09-14 17:41:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 17:46:54 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 17:48:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3a7f2e02a2a56063ee148bec097002e8c812598
Cr-Commit-Position: refs/heads/master@{#418607}

Powered by Google App Engine
This is Rietveld 408576698