Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: skia/ext/bitmap_platform_device_skia.cc

Issue 2340813006: accessBitmap is no longer called/needed (Closed)
Patch Set: peek at entire pixels Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/config/SkUserConfig.h ('k') | skia/ext/bitmap_platform_device_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/bitmap_platform_device_skia.cc
diff --git a/skia/ext/bitmap_platform_device_skia.cc b/skia/ext/bitmap_platform_device_skia.cc
index f25a5393b44200af9861a2464a46ad8ac60e6706..93d8f7d8184c760f4f004cebfec1f0586d8a4288 100644
--- a/skia/ext/bitmap_platform_device_skia.cc
+++ b/skia/ext/bitmap_platform_device_skia.cc
@@ -51,10 +51,10 @@ SkBaseDevice* BitmapPlatformDevice::onCreateDevice(const CreateInfo& info,
PlatformSurface BitmapPlatformDevice::BeginPlatformPaint(const SkMatrix& transform,
const SkIRect& clip_bounds) {
- // TODO(tomhudson): propagate transform and clip
// TODO(zhenghao): What should we return? The ptr to the address of the
// pixels? Maybe this won't be called at all.
tomhudson 2016/09/19 13:02:30 Why don't we clean up this other seemingly-obsolet
reed1 2016/09/19 13:06:58 I think its still a valid question: the return val
- return accessBitmap(true).getPixels();
+ SkPixmap pixmap;
+ return accessPixels(&pixmap) ? pixmap.writable_addr() : nullptr;
}
// PlatformCanvas impl
« no previous file with comments | « skia/config/SkUserConfig.h ('k') | skia/ext/bitmap_platform_device_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698