Chromium Code Reviews| Index: skia/ext/bitmap_platform_device_skia.cc |
| diff --git a/skia/ext/bitmap_platform_device_skia.cc b/skia/ext/bitmap_platform_device_skia.cc |
| index f25a5393b44200af9861a2464a46ad8ac60e6706..93d8f7d8184c760f4f004cebfec1f0586d8a4288 100644 |
| --- a/skia/ext/bitmap_platform_device_skia.cc |
| +++ b/skia/ext/bitmap_platform_device_skia.cc |
| @@ -51,10 +51,10 @@ SkBaseDevice* BitmapPlatformDevice::onCreateDevice(const CreateInfo& info, |
| PlatformSurface BitmapPlatformDevice::BeginPlatformPaint(const SkMatrix& transform, |
| const SkIRect& clip_bounds) { |
| - // TODO(tomhudson): propagate transform and clip |
| // TODO(zhenghao): What should we return? The ptr to the address of the |
| // pixels? Maybe this won't be called at all. |
|
tomhudson
2016/09/19 13:02:30
Why don't we clean up this other seemingly-obsolet
reed1
2016/09/19 13:06:58
I think its still a valid question: the return val
|
| - return accessBitmap(true).getPixels(); |
| + SkPixmap pixmap; |
| + return accessPixels(&pixmap) ? pixmap.writable_addr() : nullptr; |
| } |
| // PlatformCanvas impl |