accessBitmap is no longer called/needed

skia/ext/bitmap_platform_device_skia.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "skia/ext/bitmap_platform_device_skia.h"
 #include "skia/ext/platform_canvas.h"
 
 namespace skia {
 
 BitmapPlatformDevice* BitmapPlatformDevice::Create(int width, int height,
@@ skipping 33 matching lines @@
 
 SkBaseDevice* BitmapPlatformDevice::onCreateDevice(const CreateInfo& info,
                                                    const SkPaint*) {
   SkASSERT(info.fInfo.colorType() == kN32_SkColorType);
   return BitmapPlatformDevice::Create(info.fInfo.width(), info.fInfo.height(),
                                       info.fInfo.isOpaque());
 }
 
 PlatformSurface BitmapPlatformDevice::BeginPlatformPaint(const SkMatrix& transform,
                                                          const SkIRect& clip_bounds) {
-  // TODO(tomhudson): propagate transform and clip
   // TODO(zhenghao): What should we return? The ptr to the address of the
   // pixels? Maybe this won't be called at all.
-  return accessBitmap(true).getPixels();
+  SkPixmap pixmap;
+  return accessPixels(&pixmap) ? pixmap.writable_addr() : nullptr;

[tomhudson, 2016/09/16 19:37:31]

This caches a void* to the SkBitmapDevice's SkBitmap::getPixels() in the pixmap,
and then returns it - so I guess no lifetime issues, slightly roundabout but
that's how the API leans these days.

[reed1, 2016/09/16 20:29:03]

Acknowledged.

 }
 
 // PlatformCanvas impl
 
 SkCanvas* CreatePlatformCanvas(int width, int height, bool is_opaque,
                                uint8_t* data, OnFailureType failureType) {
   sk_sp<SkBaseDevice> dev(
       BitmapPlatformDevice::Create(width, height, is_opaque, data));
   return CreateCanvas(dev, failureType);
 }
 
 }  // namespace skia