Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 2340813003: Switch base::IDMap to use unique_ptr. (Closed)
Patch Set: unique_ptr<> versions of Add/AddWithId Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index 7fe73cbae3b183810dffdbe002d05cb3f0129fb9..fdf35e9398dd7940023e04de3540746fbf3a8c8f 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -551,11 +551,11 @@ int ServiceWorkerVersion::StartRequestWithCustomTimeout(
<< "Event of type " << static_cast<int>(event_type)
<< " can only be dispatched to an active worker: " << status();
- PendingRequest* request = new PendingRequest(
- error_callback, base::Time::Now(), base::TimeTicks::Now(), event_type);
- int request_id = pending_requests_.Add(request);
+ int request_id = pending_requests_.Add(base::MakeUnique<PendingRequest>(
+ error_callback, base::Time::Now(), base::TimeTicks::Now(), event_type));
TRACE_EVENT_ASYNC_BEGIN2("ServiceWorker", "ServiceWorkerVersion::Request",
- request, "Request id", request_id, "Event type",
+ pending_requests_.Lookup(request_id), "Request id",
+ request_id, "Event type",
ServiceWorkerMetrics::EventTypeToString(event_type));
base::TimeTicks expiration_time = base::TimeTicks::Now() + timeout;
timeout_queue_.push(
« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698