TaskScheduler: Match behavior of SequencedWorkerPool in RunsTasksOnCurrentThread().

TaskScheduler: Match behavior of SequencedWorkerPool in RunsTasksOnCurrentThread().

The RunsTasksOnCurrentThread() method of a SequencedTaskRunner returned
by a SequencedWorkerPool returns true iff the current task is part of
the sequence associated with the SequencedTaskRunner.

This CL changes SchedulerSequencedTaskRunner to match the behavior of
SequencedWorkerPool.

BUG=553459, 646905
Committed: https://crrev.com/04afc10b90ca1b485a3afb9404245c2fe1b7f286
Cr-Commit-Position: refs/heads/master@{#418850}

[fdoray, 2016-09-14 15:41:34]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org

[fdoray, 2016-09-14 15:41:34]

PTAL.

This CL ensures that the migration to TaskScheduler doesn't change the behavior
of RunsTasksOnCurrentThread(). RunsTasksOnCurrentThread() will be renamed in a
separate CL.

[gab, 2016-09-14 15:49:49]

lgtm, please file a bug (and associate to this CL) for the rename of
TaskRunner::RunsTasksOnCurrentThread() to kick off discussion with base/ OWNERS.

[robliao, 2016-09-14 15:50:28]

https://codereview.chromium.org/2340793002/diff/1/base/task_scheduler/schedul...
File base/task_scheduler/scheduler_worker_pool_impl_unittest.cc (right):

https://codereview.chromium.org/2340793002/diff/1/base/task_scheduler/schedul...
base/task_scheduler/scheduler_worker_pool_impl_unittest.cc:346:
EXPECT_FALSE(sequenced_task_runner->RunsTasksOnCurrentThread());
We only ever check for false for RunsTasksOnCurrentThread. Let's add a true
check as well.

[fdoray, 2016-09-14 16:55:07]

Description was changed from

==========
TaskScheduler: Match behavior of SequencedWorkerPool in
RunsTasksOnCurrentThread().

The RunsTasksOnCurrentThread() method of a SequencedTaskRunner returned
by a SequencedWorkerPool returns true iff the current task is part of
the sequence associated with the SequencedTaskRunner.

This CL changes SchedulerSequencedTaskRunner to match the behavior of
SequencedWorkerPool.

BUG=553459
==========

to

==========
TaskScheduler: Match behavior of SequencedWorkerPool in
RunsTasksOnCurrentThread().

The RunsTasksOnCurrentThread() method of a SequencedTaskRunner returned
by a SequencedWorkerPool returns true iff the current task is part of
the sequence associated with the SequencedTaskRunner.

This CL changes SchedulerSequencedTaskRunner to match the behavior of
SequencedWorkerPool.

BUG=553459,646905
==========

[fdoray, 2016-09-14 16:56:44]

robliao@: PTAnL

https://codereview.chromium.org/2340793002/diff/1/base/task_scheduler/schedul...
File base/task_scheduler/scheduler_worker_pool_impl_unittest.cc (right):

https://codereview.chromium.org/2340793002/diff/1/base/task_scheduler/schedul...
base/task_scheduler/scheduler_worker_pool_impl_unittest.cc:346:
EXPECT_FALSE(sequenced_task_runner->RunsTasksOnCurrentThread());
On 2016/09/14 15:50:27, robliao wrote:
> We only ever check for false for RunsTasksOnCurrentThread. Let's add a true
> check as well.

This is already tested by
https://cs.chromium.org/chromium/src/base/task_scheduler/test_task_factory.cc...
EXPECT_TRUE(task_runner_->RunsTasksOnCurrentThread());

(Many TaskSchedulerWorkerPoolImplTest use TestTaskFactory)

[robliao, 2016-09-14 17:20:42]

lgtm % comment

https://codereview.chromium.org/2340793002/diff/1/base/task_scheduler/schedul...
File base/task_scheduler/scheduler_worker_pool_impl_unittest.cc (right):

https://codereview.chromium.org/2340793002/diff/1/base/task_scheduler/schedul...
base/task_scheduler/scheduler_worker_pool_impl_unittest.cc:346:
EXPECT_FALSE(sequenced_task_runner->RunsTasksOnCurrentThread());
On 2016/09/14 16:56:44, fdoray wrote:
> On 2016/09/14 15:50:27, robliao wrote:
> > We only ever check for false for RunsTasksOnCurrentThread. Let's add a true
> > check as well.
> 
> This is already tested by
>
https://cs.chromium.org/chromium/src/base/task_scheduler/test_task_factory.cc...
> EXPECT_TRUE(task_runner_->RunsTasksOnCurrentThread());
> 
> (Many TaskSchedulerWorkerPoolImplTest use TestTaskFactory)

Gotcha. Let's add a quick comment about that here since we explicitly test for
false here.

[fdoray, 2016-09-15 12:19:01]

https://codereview.chromium.org/2340793002/diff/1/base/task_scheduler/schedul...
File base/task_scheduler/scheduler_worker_pool_impl_unittest.cc (right):

https://codereview.chromium.org/2340793002/diff/1/base/task_scheduler/schedul...
base/task_scheduler/scheduler_worker_pool_impl_unittest.cc:346:
EXPECT_FALSE(sequenced_task_runner->RunsTasksOnCurrentThread());
On 2016/09/14 17:20:42, robliao wrote:
> On 2016/09/14 16:56:44, fdoray wrote:
> > On 2016/09/14 15:50:27, robliao wrote:
> > > We only ever check for false for RunsTasksOnCurrentThread. Let's add a
true
> > > check as well.
> > 
> > This is already tested by
> >
>
https://cs.chromium.org/chromium/src/base/task_scheduler/test_task_factory.cc...
> > EXPECT_TRUE(task_runner_->RunsTasksOnCurrentThread());
> > 
> > (Many TaskSchedulerWorkerPoolImplTest use TestTaskFactory)
> 
> Gotcha. Let's add a quick comment about that here since we explicitly test for
> false here.

Done. Added comment about TestTaskFactory in this test.

[fdoray, 2016-09-15 12:19:39]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-09-15 12:19:39]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
robliao@chromium.org
Link to the patchset: https://codereview.chromium.org/2340793002/#ps60001
(title: "self-review (return --> returns)")

[commit-bot: I haz the power, 2016-09-15 12:20:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 13:08:34]

Description was changed from

==========
TaskScheduler: Match behavior of SequencedWorkerPool in
RunsTasksOnCurrentThread().

The RunsTasksOnCurrentThread() method of a SequencedTaskRunner returned
by a SequencedWorkerPool returns true iff the current task is part of
the sequence associated with the SequencedTaskRunner.

This CL changes SchedulerSequencedTaskRunner to match the behavior of
SequencedWorkerPool.

BUG=553459,646905
==========

to

==========
TaskScheduler: Match behavior of SequencedWorkerPool in
RunsTasksOnCurrentThread().

The RunsTasksOnCurrentThread() method of a SequencedTaskRunner returned
by a SequencedWorkerPool returns true iff the current task is part of
the sequence associated with the SequencedTaskRunner.

This CL changes SchedulerSequencedTaskRunner to match the behavior of
SequencedWorkerPool.

BUG=553459,646905
==========

[commit-bot: I haz the power, 2016-09-15 13:08:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-15 13:09:48]

Description was changed from

==========
TaskScheduler: Match behavior of SequencedWorkerPool in
RunsTasksOnCurrentThread().

The RunsTasksOnCurrentThread() method of a SequencedTaskRunner returned
by a SequencedWorkerPool returns true iff the current task is part of
the sequence associated with the SequencedTaskRunner.

This CL changes SchedulerSequencedTaskRunner to match the behavior of
SequencedWorkerPool.

BUG=553459,646905
==========

to

==========
TaskScheduler: Match behavior of SequencedWorkerPool in
RunsTasksOnCurrentThread().

The RunsTasksOnCurrentThread() method of a SequencedTaskRunner returned
by a SequencedWorkerPool returns true iff the current task is part of
the sequence associated with the SequencedTaskRunner.

This CL changes SchedulerSequencedTaskRunner to match the behavior of
SequencedWorkerPool.

BUG=553459,646905

Committed: https://crrev.com/04afc10b90ca1b485a3afb9404245c2fe1b7f286
Cr-Commit-Position: refs/heads/master@{#418850}
==========

[commit-bot: I haz the power, 2016-09-15 13:09:49]

Patchset 4 (id:??) landed as
https://crrev.com/04afc10b90ca1b485a3afb9404245c2fe1b7f286
Cr-Commit-Position: refs/heads/master@{#418850}