Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2340763003: [inspector] replaced inspector/Atomics.h with base atomicops.h (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
Reviewers:
alph, dgozman
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] replaced inspector/Atomics.h with base atomicops.h BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/3195ab9ba5a2eb5b7a9341b740b2d4be136d4b3b Cr-Commit-Position: refs/heads/master@{#39453}

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -40 lines) Patch
D src/inspector/Atomics.h View 1 chunk +0 lines, -35 lines 0 comments Download
M src/inspector/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/inspector/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M src/inspector/V8ProfilerAgentImpl.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/inspector/inspector.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
kozy
please take a look!
4 years, 3 months ago (2016-09-14 21:31:02 UTC) #1
dgozman
https://codereview.chromium.org/2340763003/diff/1/src/inspector/V8ProfilerAgentImpl.cpp File src/inspector/V8ProfilerAgentImpl.cpp (right): https://codereview.chromium.org/2340763003/diff/1/src/inspector/V8ProfilerAgentImpl.cpp#newcode283 src/inspector/V8ProfilerAgentImpl.cpp:283: v8::base::NoBarrier_AtomicIncrement(&s_lastProfileId, 1)); @alph: why do we use global counter ...
4 years, 3 months ago (2016-09-14 21:58:43 UTC) #2
alph
lgtm https://codereview.chromium.org/2340763003/diff/1/src/inspector/V8ProfilerAgentImpl.cpp File src/inspector/V8ProfilerAgentImpl.cpp (right): https://codereview.chromium.org/2340763003/diff/1/src/inspector/V8ProfilerAgentImpl.cpp#newcode283 src/inspector/V8ProfilerAgentImpl.cpp:283: v8::base::NoBarrier_AtomicIncrement(&s_lastProfileId, 1)); On 2016/09/14 21:58:43, dgozman wrote: > ...
4 years, 3 months ago (2016-09-15 17:18:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340763003/1
4 years, 3 months ago (2016-09-15 17:39:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340763003/20001
4 years, 3 months ago (2016-09-15 17:40:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 18:29:55 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 18:30:45 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3195ab9ba5a2eb5b7a9341b740b2d4be136d4b3b
Cr-Commit-Position: refs/heads/master@{#39453}

Powered by Google App Engine
This is Rietveld 408576698