Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2340743002: Modify error messages for payment address validation as per specification. (Closed)

Created:
4 years, 3 months ago by pals
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify error messages for payment address validation as per specification. Specification https://w3c.github.io/browser-payment-api/ BUG=640847 Committed: https://crrev.com/2465b1d8154ac1b482c0e3ec86df89d33fb9af6e Cr-Commit-Position: refs/heads/master@{#418888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
pals
PTAL.
4 years, 3 months ago (2016-09-14 11:21:57 UTC) #5
please use gerrit instead
lgtm Thank you for this patch.
4 years, 3 months ago (2016-09-15 15:26:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340743002/1
4 years, 3 months ago (2016-09-15 15:27:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 16:57:13 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:10:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2465b1d8154ac1b482c0e3ec86df89d33fb9af6e
Cr-Commit-Position: refs/heads/master@{#418888}

Powered by Google App Engine
This is Rietveld 408576698