src/IceTargetLoweringMIPS32.cpp - Issue 2340733003: Subzero, MIPS32: Randomly insert NOP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringMIPS32.cpp

Issue 2340733003: Subzero, MIPS32: Randomly insert NOP (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addressing review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/IceTargetLoweringMIPS32.h ('k') | tests_lit/llvm2ice_tests/nop-insertion-no-vectors.ll » ('j') | tests_lit/llvm2ice_tests/nop-insertion-no-vectors.ll » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/IceTargetLoweringMIPS32.cpp

diff --git a/src/IceTargetLoweringMIPS32.cpp b/src/IceTargetLoweringMIPS32.cpp

index d74a8d80144a5f0fbce8726e65d5c31d941b0a42..c4b602463f20af75a03df68d14f4f43a92998fa5 100644

--- a/src/IceTargetLoweringMIPS32.cpp

+++ b/src/IceTargetLoweringMIPS32.cpp

@@ -3196,7 +3196,7 @@ void TargetMIPS32::randomlyInsertNop(float Probability,

RandomNumberGenerator &RNG) {

RandomNumberGeneratorWrapper RNGW(RNG);

if (RNGW.getTrueWithProbability(Probability)) {

- UnimplementedError(getFlags());

+ _nop();

}