pydir/run-pnacl-sz.py - Issue 2340733003: Subzero, MIPS32: Randomly insert NOP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pydir/run-pnacl-sz.py

Issue 2340733003: Subzero, MIPS32: Randomly insert NOP (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addressing review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: pydir/run-pnacl-sz.py

diff --git a/pydir/run-pnacl-sz.py b/pydir/run-pnacl-sz.py

index 580d227b32384523ccd191e5548e7c2b454a422c..a9267eafba74db9c8d418e80ac7b8f3e5af55bb1 100755

--- a/pydir/run-pnacl-sz.py

+++ b/pydir/run-pnacl-sz.py

@@ -202,10 +202,11 @@ def main():

elif output_file_name:

cmd += ['-o', output_file_name]

if args.disassemble:

- # Show wide instruction encodings, diassemble, and show relocs.

+ # Show wide instruction encodings, diassemble, show relocs and

+ # dissasemble zeros.

cmd += (['&&', os.path.join(pnacl_bin_path, GetObjdumpCmd())] +

args.dis_flags +

- ['-w', '-d', '-r'] + TargetDisassemblerFlags(args.target) +

+ ['-w', '-d', '-r', '-z'] + TargetDisassemblerFlags(args.target) +

[output_file_name])

stdout_result = shellcmd(cmd, echo=args.echo_cmd)

« no previous file with comments | « no previous file | src/IceTargetLoweringMIPS32.h » ('j') | tests_lit/llvm2ice_tests/nop-insertion-no-vectors.ll » ('J')