Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3900)

Unified Diff: chrome/common/chrome_content_client.cc

Issue 2340643002: Do not reference non-existant bundled flash on Chrome OS. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/adobe/flash/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_content_client.cc
diff --git a/chrome/common/chrome_content_client.cc b/chrome/common/chrome_content_client.cc
index eb4d107e69992982a04248824dae12a4387911cf..537d45d1e8d509641f5383f96ff2c9b758958693 100644
--- a/chrome/common/chrome_content_client.cc
+++ b/chrome/common/chrome_content_client.cc
@@ -340,35 +340,6 @@ bool GetComponentUpdatedPepperFlash(content::PepperPluginInfo* plugin) {
}
#endif // defined(OS_LINUX)
-#if defined(OS_CHROMEOS)
-// This should be used on ChromeOS only - other platforms do not bundle Flash.
-bool GetBundledPepperFlash(content::PepperPluginInfo* plugin) {
-#if defined(FLAPPER_AVAILABLE)
- base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-
- // Ignore bundled Pepper Flash if there is Pepper Flash specified from the
- // command-line.
- if (command_line->HasSwitch(switches::kPpapiFlashPath))
- return false;
-
- bool force_disable =
- command_line->HasSwitch(switches::kDisableBundledPpapiFlash);
- if (force_disable)
- return false;
-
- base::FilePath flash_path;
- if (!PathService::Get(chrome::FILE_PEPPER_FLASH_PLUGIN, &flash_path))
- return false;
-
- *plugin = CreatePepperFlashInfo(flash_path, FLAPPER_VERSION_STRING, false,
- false, true);
- return true;
-#else
- return false;
-#endif // FLAPPER_AVAILABLE
-}
-#endif // defined(OS_CHROMEOS)
-
bool GetSystemPepperFlash(content::PepperPluginInfo* plugin) {
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
// Do not try and find System Pepper Flash if there is a specific path on
@@ -536,13 +507,6 @@ void ChromeContentClient::AddPepperPlugins(
flash_versions.push_back(component_flash.release());
#endif // defined(OS_LINUX)
-#if defined(OS_CHROMEOS)
- std::unique_ptr<content::PepperPluginInfo> bundled_flash(
- new content::PepperPluginInfo);
- if (GetBundledPepperFlash(bundled_flash.get()))
- flash_versions.push_back(bundled_flash.release());
-#endif // defined(OS_CHROMEOS)
-
std::unique_ptr<content::PepperPluginInfo> system_flash(
new content::PepperPluginInfo);
if (GetSystemPepperFlash(system_flash.get()))
« no previous file with comments | « no previous file | third_party/adobe/flash/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698