Issue 234063004: Refactoring: Get rid of HTMLImportRoot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 234063004: Refactoring: Get rid of HTMLImportRoot. (Closed)

Created:
6 years, 8 months ago by Hajime Morrita

Modified:
6 years, 8 months ago

Reviewers:
dglazkov, dominicc (has gone to gerrit)

CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Refactoring: Get rid of HTMLImportRoot. This CL removes HTMLImportRoot abstract class and merge it into HTMLImportsController. TEST=none BUG=none R=dglazkov@chromium.org, dominicc@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171390

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -46 lines)			Patch
M	Source/core/html/imports/HTMLImport.h	View	7 chunks	+7 lines, -19 lines	0 comments	Download
M	Source/core/html/imports/HTMLImport.cpp	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	Source/core/html/imports/HTMLImportChild.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/imports/HTMLImportChild.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/html/imports/HTMLImportsController.h	View	4 chunks	+6 lines, -7 lines	0 comments	Download
M	Source/core/html/imports/HTMLImportsController.cpp	View	3 chunks	+7 lines, -6 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/234063004/1

6 years, 8 months ago (2014-04-10 23:02:45 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/234063004/1

6 years, 8 months ago (2014-04-11 23:53:21 UTC) #5

Message was sent while issue was closed.

Change committed as 171390