Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2340623003:
[wasm] Strongly typed compiled module (Closed)
|
Created:
4 years, 3 months ago by Mircea Trofin Modified:
4 years, 2 months ago Reviewers:
bradnelson CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] Strongly typed compiled module
First stab at strongly typing the wasm compiled module FixedArray. The goal
is to improve maintainability of the data structures living on the JS heap.
My goal is to do so just for the first level, since we plan to eventually
avoid copying the metadata bits that are currently copied from the decoded
structures (export/import metadata, etc).
Subsequent CLs will try and consolidate internal functions working off the
compiled module as members, and evaluate what the actual interface with the
rest of the world of this type should be - we may be able to completely
move it in the cc file, for instance.
BUG=
Committed: https://crrev.com/6e03b72d9d7c0d69a4222981687757ffb0737236
Committed: https://crrev.com/7369469a0f6f6b5c911eb4991fd3573be0c32773
Cr-Original-Commit-Position: refs/heads/master@{#39890}
Cr-Commit-Position: refs/heads/master@{#39894}
Patch Set 1 #
Total comments: 2
Patch Set 2 : xmacro #Patch Set 3 : xmacro #Patch Set 4 : const #Patch Set 5 : after 0xC #Patch Set 6 : after 0xC #Patch Set 7 : after 0xC #Patch Set 8 : Fix build failure #Messages
Total messages: 56 (42 generated)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [wasm] Strongly typed compiled module First stab at strongly typing the wasm compiled module FixedArray. The goal is to improve maintainability of the data structures living on the JS heap. My goal is to do so just for the first level, since we plan to eventually avoid copying the metadata bits that are currently copied from the decoded structures (export/import metadata, etc). Subsequent CLs will try and consolidate internal functions working off the compiled module as members, and evaluate what the actual interface with the rest of the world of this type should be - we may be able to completely move it in the cc file, for instance. BUG= ========== to ========== [wasm] Strongly typed compiled module First stab at strongly typing the wasm compiled module FixedArray. The goal is to improve maintainability of the data structures living on the JS heap. My goal is to do so just for the first level, since we plan to eventually avoid copying the metadata bits that are currently copied from the decoded structures (export/import metadata, etc). Subsequent CLs will try and consolidate internal functions working off the compiled module as members, and evaluate what the actual interface with the rest of the world of this type should be - we may be able to completely move it in the cc file, for instance. BUG= ==========
mtrofin@chromium.org changed reviewers: + bradnelson@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
https://codereview.chromium.org/2340623003/diff/1/src/wasm/wasm-module.h File src/wasm/wasm-module.h (right): https://codereview.chromium.org/2340623003/diff/1/src/wasm/wasm-module.h#newc... src/wasm/wasm-module.h:402: WCM_PROPERTY(0, FixedArray, functions); Use x-macros as discussed.
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2340623003/diff/1/src/wasm/wasm-module.h File src/wasm/wasm-module.h (right): https://codereview.chromium.org/2340623003/diff/1/src/wasm/wasm-module.h#newc... src/wasm/wasm-module.h:402: WCM_PROPERTY(0, FixedArray, functions); On 2016/09/13 23:54:49, bradnelson wrote: > Use x-macros as discussed. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2340623003/#ps80001 (title: "after 0xC")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2340623003/#ps120001 (title: "after 0xC")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [wasm] Strongly typed compiled module First stab at strongly typing the wasm compiled module FixedArray. The goal is to improve maintainability of the data structures living on the JS heap. My goal is to do so just for the first level, since we plan to eventually avoid copying the metadata bits that are currently copied from the decoded structures (export/import metadata, etc). Subsequent CLs will try and consolidate internal functions working off the compiled module as members, and evaluate what the actual interface with the rest of the world of this type should be - we may be able to completely move it in the cc file, for instance. BUG= ========== to ========== [wasm] Strongly typed compiled module First stab at strongly typing the wasm compiled module FixedArray. The goal is to improve maintainability of the data structures living on the JS heap. My goal is to do so just for the first level, since we plan to eventually avoid copying the metadata bits that are currently copied from the decoded structures (export/import metadata, etc). Subsequent CLs will try and consolidate internal functions working off the compiled module as members, and evaluate what the actual interface with the rest of the world of this type should be - we may be able to completely move it in the cc file, for instance. BUG= ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] Strongly typed compiled module First stab at strongly typing the wasm compiled module FixedArray. The goal is to improve maintainability of the data structures living on the JS heap. My goal is to do so just for the first level, since we plan to eventually avoid copying the metadata bits that are currently copied from the decoded structures (export/import metadata, etc). Subsequent CLs will try and consolidate internal functions working off the compiled module as members, and evaluate what the actual interface with the rest of the world of this type should be - we may be able to completely move it in the cc file, for instance. BUG= ========== to ========== [wasm] Strongly typed compiled module First stab at strongly typing the wasm compiled module FixedArray. The goal is to improve maintainability of the data structures living on the JS heap. My goal is to do so just for the first level, since we plan to eventually avoid copying the metadata bits that are currently copied from the decoded structures (export/import metadata, etc). Subsequent CLs will try and consolidate internal functions working off the compiled module as members, and evaluate what the actual interface with the rest of the world of this type should be - we may be able to completely move it in the cc file, for instance. BUG= Committed: https://crrev.com/6e03b72d9d7c0d69a4222981687757ffb0737236 Cr-Commit-Position: refs/heads/master@{#39890} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/6e03b72d9d7c0d69a4222981687757ffb0737236 Cr-Commit-Position: refs/heads/master@{#39890}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Strongly typed compiled module First stab at strongly typing the wasm compiled module FixedArray. The goal is to improve maintainability of the data structures living on the JS heap. My goal is to do so just for the first level, since we plan to eventually avoid copying the metadata bits that are currently copied from the decoded structures (export/import metadata, etc). Subsequent CLs will try and consolidate internal functions working off the compiled module as members, and evaluate what the actual interface with the rest of the world of this type should be - we may be able to completely move it in the cc file, for instance. BUG= Committed: https://crrev.com/6e03b72d9d7c0d69a4222981687757ffb0737236 Cr-Commit-Position: refs/heads/master@{#39890} ========== to ========== [wasm] Strongly typed compiled module First stab at strongly typing the wasm compiled module FixedArray. The goal is to improve maintainability of the data structures living on the JS heap. My goal is to do so just for the first level, since we plan to eventually avoid copying the metadata bits that are currently copied from the decoded structures (export/import metadata, etc). Subsequent CLs will try and consolidate internal functions working off the compiled module as members, and evaluate what the actual interface with the rest of the world of this type should be - we may be able to completely move it in the cc file, for instance. BUG= Committed: https://crrev.com/6e03b72d9d7c0d69a4222981687757ffb0737236 Cr-Commit-Position: refs/heads/master@{#39890} ==========
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2340623003/#ps140001 (title: "Revert "[wasm] Strongly typed compiled module"")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by mtrofin@chromium.org
Patchset #8 (id:140001) has been deleted
Message was sent while issue was closed.
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/2383623003/ by mtrofin@chromium.org. The reason for reverting is: Forgot to correctly clone a heap number. Reverting to fix..
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2340623003/#ps160001 (title: "Fix build failure")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [wasm] Strongly typed compiled module First stab at strongly typing the wasm compiled module FixedArray. The goal is to improve maintainability of the data structures living on the JS heap. My goal is to do so just for the first level, since we plan to eventually avoid copying the metadata bits that are currently copied from the decoded structures (export/import metadata, etc). Subsequent CLs will try and consolidate internal functions working off the compiled module as members, and evaluate what the actual interface with the rest of the world of this type should be - we may be able to completely move it in the cc file, for instance. BUG= Committed: https://crrev.com/6e03b72d9d7c0d69a4222981687757ffb0737236 Cr-Commit-Position: refs/heads/master@{#39890} ========== to ========== [wasm] Strongly typed compiled module First stab at strongly typing the wasm compiled module FixedArray. The goal is to improve maintainability of the data structures living on the JS heap. My goal is to do so just for the first level, since we plan to eventually avoid copying the metadata bits that are currently copied from the decoded structures (export/import metadata, etc). Subsequent CLs will try and consolidate internal functions working off the compiled module as members, and evaluate what the actual interface with the rest of the world of this type should be - we may be able to completely move it in the cc file, for instance. BUG= Committed: https://crrev.com/6e03b72d9d7c0d69a4222981687757ffb0737236 Cr-Commit-Position: refs/heads/master@{#39890} ==========
Message was sent while issue was closed.
Committed patchset #8 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] Strongly typed compiled module First stab at strongly typing the wasm compiled module FixedArray. The goal is to improve maintainability of the data structures living on the JS heap. My goal is to do so just for the first level, since we plan to eventually avoid copying the metadata bits that are currently copied from the decoded structures (export/import metadata, etc). Subsequent CLs will try and consolidate internal functions working off the compiled module as members, and evaluate what the actual interface with the rest of the world of this type should be - we may be able to completely move it in the cc file, for instance. BUG= Committed: https://crrev.com/6e03b72d9d7c0d69a4222981687757ffb0737236 Cr-Commit-Position: refs/heads/master@{#39890} ========== to ========== [wasm] Strongly typed compiled module First stab at strongly typing the wasm compiled module FixedArray. The goal is to improve maintainability of the data structures living on the JS heap. My goal is to do so just for the first level, since we plan to eventually avoid copying the metadata bits that are currently copied from the decoded structures (export/import metadata, etc). Subsequent CLs will try and consolidate internal functions working off the compiled module as members, and evaluate what the actual interface with the rest of the world of this type should be - we may be able to completely move it in the cc file, for instance. BUG= Committed: https://crrev.com/6e03b72d9d7c0d69a4222981687757ffb0737236 Committed: https://crrev.com/7369469a0f6f6b5c911eb4991fd3573be0c32773 Cr-Original-Commit-Position: refs/heads/master@{#39890} Cr-Commit-Position: refs/heads/master@{#39894} ==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/7369469a0f6f6b5c911eb4991fd3573be0c32773 Cr-Commit-Position: refs/heads/master@{#39894} |
