[inspector] removed ArrayLengthHelperFunction specialization for empty array

[inspector] removed ArrayLengthHelperFunction specialization for empty array

There is no zero length array usage in inspector codebase. We can safely remove template specialization.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/b249ffc1915d8c35ff66eae3d51d3878d588dfbf
Cr-Commit-Position: refs/heads/master@{#39428}

[kozy, 2016-09-13 21:43:53]

Dmitry and Alexei, please take a look.

[dgozman, 2016-09-13 22:07:54]

lgtm

[kozy, 2016-09-13 22:12:55]

Description was changed from

==========
[inspector] removed ArrayLengthHelperFunction specialization for empty array

There is no zero length array usage in inspector codebase. We can safely remove
template specialization.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] removed ArrayLengthHelperFunction specialization for empty array

There is no zero length array usage in inspector codebase. We can safely remove
template specialization.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

[kozy, 2016-09-13 22:12:55]

kozyatinskiy@chromium.org changed reviewers:
+ jochen@chromium.org

[kozy, 2016-09-13 22:13:17]

@jochen, please take a look. I need owner lgtm for v8.gyp.

[jochen (gone - plz use gerrit), 2016-09-14 08:43:44]

lgtm

[kozy, 2016-09-14 18:00:01]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-09-14 18:00:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 18:25:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 18:25:59]

Failed to apply patch for src/v8.gyp:
While running git apply --index -3 -p1;
  error: patch failed: src/v8.gyp:1756
  Falling back to three-way merge...
  Applied patch to 'src/v8.gyp' with conflicts.
  U src/v8.gyp

Patch:       src/v8.gyp
Index: src/v8.gyp
diff --git a/src/v8.gyp b/src/v8.gyp
index
e75589fa827395c11759d4fd79034f96077a81a4..0477ad7f62a7e55f80d3a16527920299e5eb67e5
100644
--- a/src/v8.gyp
+++ b/src/v8.gyp
@@ -1756,7 +1756,6 @@
             4996,  # Deprecated function call.
           ],
           'cflags': [
-            '-Wno-zero-length-array',
             '-Wno-shorten-64-to-32',
             '-Wno-deprecated-declarations',
           ],

[kozy, 2016-09-14 18:37:15]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-09-14 18:37:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2340623002/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2016-09-14 18:37:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 19:04:53]

Description was changed from

==========
[inspector] removed ArrayLengthHelperFunction specialization for empty array

There is no zero length array usage in inspector codebase. We can safely remove
template specialization.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] removed ArrayLengthHelperFunction specialization for empty array

There is no zero length array usage in inspector codebase. We can safely remove
template specialization.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

[commit-bot: I haz the power, 2016-09-14 19:04:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-14 19:05:17]

Description was changed from

==========
[inspector] removed ArrayLengthHelperFunction specialization for empty array

There is no zero length array usage in inspector codebase. We can safely remove
template specialization.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] removed ArrayLengthHelperFunction specialization for empty array

There is no zero length array usage in inspector codebase. We can safely remove
template specialization.

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/b249ffc1915d8c35ff66eae3d51d3878d588dfbf
Cr-Commit-Position: refs/heads/master@{#39428}
==========

[commit-bot: I haz the power, 2016-09-14 19:05:18]

Patchset 2 (id:??) landed as
https://crrev.com/b249ffc1915d8c35ff66eae3d51d3878d588dfbf
Cr-Commit-Position: refs/heads/master@{#39428}

[Michael Hablich, 2016-09-15 00:38:04]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2334163006/ by hablich@chromium.org.

The reason for reverting is: needed to revert
https://codereview.chromium.org/2339173004/.