Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2340613002: Add UMA to measure time to open hyphenation dictionary (Closed)

Created:
4 years, 3 months ago by kojii
Modified:
4 years, 3 months ago
Reviewers:
eae, Steven Holte
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA to measure time to open hyphenation dictionary This patch adds UMA to measure time to open hyphenation dictionary. The previous CL[1] added UMA that includes IPC as "Hyphenation.Open", but this metric measures the time of the file task without the IPC. [1] 2113933003 BUG=605840 Committed: https://crrev.com/da78af241006da0957f090d3678bffe4d7780f15 Cr-Commit-Position: refs/heads/master@{#418826}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/browser/hyphenation/hyphenation_impl.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
kojii
PTAL.
4 years, 3 months ago (2016-09-14 03:51:50 UTC) #11
Steven Holte
histograms lgtm
4 years, 3 months ago (2016-09-14 23:39:31 UTC) #12
eae
LGTM
4 years, 3 months ago (2016-09-15 09:22:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340613002/20001
4 years, 3 months ago (2016-09-15 09:28:21 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 10:23:03 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 10:25:16 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da78af241006da0957f090d3678bffe4d7780f15
Cr-Commit-Position: refs/heads/master@{#418826}

Powered by Google App Engine
This is Rietveld 408576698