Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2340603004: Removed webrtc::RTCStatsMemberInterface::k[Sequence]StaticString usages. (Closed)

Created:
4 years, 3 months ago by hbos_chromium
Modified:
4 years, 3 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed webrtc::RTCStatsMemberInterface::k[Sequence]StaticString usages. Currently there are const char* and std::string varieties of strings in RTCStatsMember objects ("StaticString" and "String"). The const char* version is going away so that we don't have two string types. This CL removes references to the "StaticString" types so that a WebRTC CL can remove it without breaking Chromium. Only rtc_stats.cc have to be updated, not affecting any code because rtc_stats is not used yet (a CL is in the works that will use it and add unittests for it that is blocked on a WebRTC CL that is under review). BUG=chromium:627816 Committed: https://crrev.com/3b022272fd85b6dc286d4d851ad02da7d5c551e3 Cr-Commit-Position: refs/heads/master@{#418845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -38 lines) Patch
M content/renderer/media/webrtc/rtc_stats.cc View 4 chunks +8 lines, -38 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
hbos_chromium
Please take a look, perkj. (Tiny CL)
4 years, 3 months ago (2016-09-15 10:44:54 UTC) #4
hbos_chromium
On 2016/09/15 10:44:54, hbos_chromium wrote: > Please take a look, perkj. (Tiny CL) Holding off ...
4 years, 3 months ago (2016-09-15 12:42:47 UTC) #7
perkj_chrome
lgtm
4 years, 3 months ago (2016-09-15 12:49:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340603004/1
4 years, 3 months ago (2016-09-15 12:50:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 12:55:19 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 12:57:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b022272fd85b6dc286d4d851ad02da7d5c551e3
Cr-Commit-Position: refs/heads/master@{#418845}

Powered by Google App Engine
This is Rietveld 408576698