Issue 23406003: Fix race in fast/loader/onunload-form-submit-crash.html.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23406003: Fix race in fast/loader/onunload-form-submit-crash.html. (Closed)

Created:
7 years, 4 months ago by ojan

Modified:
7 years, 4 months ago

Reviewers:
rjkroege, abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Fix race in fast/loader/onunload-form-submit-crash.html. The setTimeout was sometimes firing before the form was parsed, so document.myForm would be null. BUG=278518 R=rjkroege@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156656

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	LayoutTests/fast/loader/onunload-form-submit-crash.html	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

rjkroege

change is lgtm. do you want to clear the TestExpectations with this patch or should ...

7 years, 4 months ago (2013-08-23 21:19:04 UTC) #2

ojan

7 years, 4 months ago (2013-08-23 21:20:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r156656 (presubmit successful).