Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 2340583006: Rollback 6bee780067d3c84bfbc387720a26b0eabe7c2357, restore PrintWriter. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rollback 6bee780067d3c84bfbc387720a26b0eabe7c2357, restore PrintWriter. As we decided, this change conflicts with Angular and other packages, so it should be rolled back. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8c7790215cd41178feaf5267207ba650d8416a46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -179 lines) Patch
M pkg/analyzer/lib/src/dart/ast/ast.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 55 chunks +174 lines, -173 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 2 chunks +66 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-15 17:58:11 UTC) #1
Brian Wilkerson
But kept to be re-applied later. lgtm
4 years, 3 months ago (2016-09-15 18:03:54 UTC) #2
scheglov
4 years, 3 months ago (2016-09-15 18:32:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c7790215cd41178feaf5267207ba650d8416a46 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698