Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 2340583002: Make DiversificationNonce a std::array (Closed)

Created:
4 years, 3 months ago by Ryan Hamilton
Modified:
4 years, 3 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DiversificationNonce a std::array Changing a char[32] to a std::array<char, 32>. No functional change intended, not flag-protected Merge internal change: 132456567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M net/quic/core/crypto/aead_base_decrypter.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/aead_base_decrypter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/crypto/null_decrypter.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/null_decrypter.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/quic_decrypter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/quic_decrypter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_connection.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_connection_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_framer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_packet_creator.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_packet_creator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_packet_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_packet_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_protocol.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/core/quic_protocol.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
Ryan Hamilton
4 years, 3 months ago (2016-09-13 20:30:25 UTC) #2
Zhongyi Shi
4 years, 3 months ago (2016-09-13 20:56:29 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698