Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2340573002: ImageCapture: Connect takePhoto() VideoCaptureDeviceTest (Closed)

Created:
4 years, 3 months ago by mcasas
Modified:
4 years, 3 months ago
Reviewers:
emircan, chfremer
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ImageCapture: Connect takePhoto() VideoCaptureDeviceTest This CL enables VideoCaptureDeviceTest.TakePhoto for Android. (Note that, due to other circumstances, it'll only be enabled for devices implementing the Camera2 API in non-legacy mode). The only modification is that Android creates JPEGs with APP1 JFIF header, because it includes EXIF information. BUG=518807, 626857 Committed: https://crrev.com/a8ae6bfb0e432ee220b641b0e8bb3f4800a7448a Cr-Commit-Position: refs/heads/master@{#418423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/capture/video/video_capture_device_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mcasas
emircan@/chfremer@ PTAL
4 years, 3 months ago (2016-09-13 21:24:24 UTC) #4
emircan
lgtm
4 years, 3 months ago (2016-09-13 22:38:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340573002/1
4 years, 3 months ago (2016-09-13 22:48:06 UTC) #7
chfremer
lgtm
4 years, 3 months ago (2016-09-13 22:48:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 00:05:41 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a8ae6bfb0e432ee220b641b0e8bb3f4800a7448a Cr-Commit-Position: refs/heads/master@{#418423}
4 years, 3 months ago (2016-09-14 00:09:08 UTC) #12
aberent
4 years, 3 months ago (2016-09-14 16:21:31 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2344503003/ by aberent@chromium.org.

The reason for reverting is: Fails on Android L.

BUG=646840.

Powered by Google App Engine
This is Rietveld 408576698