Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 2340533002: Don't paint ellipsis selection (Closed)

Created:
4 years, 3 months ago by rhogan
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't paint ellipsis selection FF and Edge don't paint a selection on the ellipsis. BUG=642460 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4 Cr-Commit-Position: refs/heads/master@{#419379}

Patch Set 1 #

Patch Set 2 : bug 642460 #

Patch Set 3 : bug 642460 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -37 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/text-overflow-ellipsis-vertical-select-expected.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/Source/core/paint/EllipsisBoxPainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/EllipsisBoxPainter.cpp View 1 2 chunks +3 lines, -35 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
rhogan
4 years, 3 months ago (2016-09-16 22:33:35 UTC) #10
eae
LGTM Seems reasonable now that we have disabled selection gaps.
4 years, 3 months ago (2016-09-17 08:30:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340533002/20001
4 years, 3 months ago (2016-09-17 08:30:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340533002/40001
4 years, 3 months ago (2016-09-17 09:09:12 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-17 19:43:49 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 19:45:53 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b066a99dbd93ff5ceed0f9488a2e9737138434d4
Cr-Commit-Position: refs/heads/master@{#419379}

Powered by Google App Engine
This is Rietveld 408576698