Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2340513002: Remove more strcmp/memcmp usage. (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -41 lines) Patch
M core/fpdfapi/fpdf_cmaps/cmap_int.h View 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_font/font_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 3 chunks +13 lines, -13 lines 0 comments Download
M fpdfsdk/fpdfppo.cpp View 1 chunk +4 lines, -9 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ScrollBar.h View 2 chunks +27 lines, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_ScrollBar.cpp View 1 2 2 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Tom Sepez
Dan, for review.
4 years, 3 months ago (2016-09-13 18:43:34 UTC) #2
dsinclair
lgtm w/ nit https://codereview.chromium.org/2340513002/diff/1/fpdfsdk/pdfwindow/PWL_ScrollBar.cpp File fpdfsdk/pdfwindow/PWL_ScrollBar.cpp (right): https://codereview.chromium.org/2340513002/diff/1/fpdfsdk/pdfwindow/PWL_ScrollBar.cpp#newcode821 fpdfsdk/pdfwindow/PWL_ScrollBar.cpp:821: PWL_SCROLL_INFO* pInfo = (PWL_SCROLL_INFO*)lParam; static_cast?
4 years, 3 months ago (2016-09-13 18:49:48 UTC) #3
Tom Sepez
https://codereview.chromium.org/2340513002/diff/1/fpdfsdk/pdfwindow/PWL_ScrollBar.cpp File fpdfsdk/pdfwindow/PWL_ScrollBar.cpp (right): https://codereview.chromium.org/2340513002/diff/1/fpdfsdk/pdfwindow/PWL_ScrollBar.cpp#newcode821 fpdfsdk/pdfwindow/PWL_ScrollBar.cpp:821: PWL_SCROLL_INFO* pInfo = (PWL_SCROLL_INFO*)lParam; On 2016/09/13 18:49:48, dsinclair wrote: ...
4 years, 3 months ago (2016-09-13 19:10:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340513002/40001
4 years, 3 months ago (2016-09-13 19:10:45 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 19:23:33 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/f86ca3884886506c999a3b521078151e7cda...

Powered by Google App Engine
This is Rietveld 408576698