Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2340503002: Fix appearance of disabled VectorIconButtons. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix appearance of disabled VectorIconButtons. Ironically, removing OnEnabledChanged() fixes this bug. Not calling through to the parent class's implementation was problematic, but it turns out that handling changes to the enable state isn't necessary anyway since that's done with the state parameter of ImageButton::SetImage(). BUG=645353 Committed: https://crrev.com/4aabce05f776aa8c56e1d208f9c27423ea90690b Cr-Commit-Position: refs/heads/master@{#418431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M ui/views/controls/button/vector_icon_button.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/button/vector_icon_button.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
4 years, 3 months ago (2016-09-13 17:58:02 UTC) #2
sadrul
lgtm
4 years, 3 months ago (2016-09-13 22:45:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340503002/1
4 years, 3 months ago (2016-09-13 23:05:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 00:15:25 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 00:17:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4aabce05f776aa8c56e1d208f9c27423ea90690b
Cr-Commit-Position: refs/heads/master@{#418431}

Powered by Google App Engine
This is Rietveld 408576698