Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2340483002: Revert of Add better documentation, trigger namedtuple. (Closed)

Created:
4 years, 3 months ago by martiniss
Modified:
4 years, 3 months ago
Reviewers:
dnj, iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Add better documentation, trigger namedtuple. (patchset #3 id:40001 of https://codereview.chromium.org/2332833003/ ) Reason for revert: help -> helptext change broke roller badly. Original issue's description: > Add better documentation, trigger namedtuple. > > Follow-up to https://codereview.chromium.org/2253943003: > - Add much better comments to StepConfig fields. > - Add rendering logic directly to StepConfig. > - Add "cmd=[]" output to simulation results. > - Make "trigger_specs" a namedtuple. > > BUG=None > TEST=expectations > > Committed: https://github.com/luci/recipes-py/commit/8ad49e0698f1e74e3f500fda6ca5b65a2af29fd0 TBR=iannucci@chromium.org,dnj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://github.com/luci/recipes-py/commit/dbdcd3b5c9096b3a770bdb61e15039115b6a8dd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -172 lines) Patch
M recipe_engine/recipe_api.py View 8 chunks +56 lines, -144 lines 0 comments Download
M recipe_engine/run.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_engine/step_runner.py View 5 chunks +19 lines, -9 lines 0 comments Download
M recipe_engine/stream.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/platform/example.expected/linux64.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/platform/example.expected/mac64.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/platform/example.expected/win32.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/step/example.expected/basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/step/example.expected/defer_results.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/step/example.expected/exceptional.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/step/example.expected/infra_failure.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/step/example.expected/invalid_access.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_modules/step/example.expected/warning.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/engine_tests/trigger.expected/basic.json View 1 chunk +0 lines, -1 line 0 comments Download
M recipes/example/nested.expected/basic.json View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
martiniss
Created Revert of Add better documentation, trigger namedtuple.
4 years, 3 months ago (2016-09-13 17:11:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340483002/1
4 years, 3 months ago (2016-09-13 17:11:57 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 17:12:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/dbdcd3b5c9096b3a770bdb61e15039115b6...

Powered by Google App Engine
This is Rietveld 408576698