Remove clear /data/local/tmp steps.

Remove clear /data/local/tmp steps.

These were intended to prevent GN and GYP Android bots from stomping on
each other.  Turns out, they don't, even without this... they're writing
most files to completely separate paths:
  - GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard
    and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher)
    in /data/local/tmp;
  - GN puts everything under /data/local/tmp, and its binaries (dm, nanobench)
    don't overlap GYP's.

So clearing /data/local/tmp was essentially just removing GN's data; GYP's
data file caching was never affected and can't conflict with GN's.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340473002

Committed: https://skia.googlesource.com/skia/+/649985a530c39afcda23d1f188fa2fc92df3ac56

[mtklein_C, 2016-09-13 16:52:09]

Description was changed from

==========
Remove clear /data/local/tmp steps.

These were intended to prevent GN and GYP Android bots from stomping on
each other.  Turns out, they don't, even without this... they're writing
most files to completely separate paths:
  - GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard
    and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher)
    in /data/local/tmp;
  - GN puts everything under /data/local/tmp, and its binaries (dm, nanobench)
    don't overlap GYP's.

So clearing /data/local/tmp was essentially just removing GN's data; GYP's
data file caching was never affected and can't conflict with GN's.


BUG=skia:
==========

to

==========
Remove clear /data/local/tmp steps.

These were intended to prevent GN and GYP Android bots from stomping on
each other.  Turns out, they don't, even without this... they're writing
most files to completely separate paths:
  - GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard
    and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher)
    in /data/local/tmp;
  - GN puts everything under /data/local/tmp, and its binaries (dm, nanobench)
    don't overlap GYP's.

So clearing /data/local/tmp was essentially just removing GN's data; GYP's
data file caching was never affected and can't conflict with GN's.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340473002
==========

[mtklein_C, 2016-09-13 17:05:04]

mtklein@chromium.org changed reviewers:
+ borenet@google.com

[borenet, 2016-09-13 17:24:24]

LGTM

[mtklein_C, 2016-09-13 17:29:02]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-09-13 17:29:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 18:18:00]

Description was changed from

==========
Remove clear /data/local/tmp steps.

These were intended to prevent GN and GYP Android bots from stomping on
each other.  Turns out, they don't, even without this... they're writing
most files to completely separate paths:
  - GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard
    and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher)
    in /data/local/tmp;
  - GN puts everything under /data/local/tmp, and its binaries (dm, nanobench)
    don't overlap GYP's.

So clearing /data/local/tmp was essentially just removing GN's data; GYP's
data file caching was never affected and can't conflict with GN's.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340473002
==========

to

==========
Remove clear /data/local/tmp steps.

These were intended to prevent GN and GYP Android bots from stomping on
each other.  Turns out, they don't, even without this... they're writing
most files to completely separate paths:
  - GYP puts most data under $EXTERNAL_STORAGE, generally /sdcard
    and its binaries (libdm.so, libnanobench.so, libskia.so, skia_launcher)
    in /data/local/tmp;
  - GN puts everything under /data/local/tmp, and its binaries (dm, nanobench)
    don't overlap GYP's.

So clearing /data/local/tmp was essentially just removing GN's data; GYP's
data file caching was never affected and can't conflict with GN's.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340473002

Committed:
https://skia.googlesource.com/skia/+/649985a530c39afcda23d1f188fa2fc92df3ac56
==========

[commit-bot: I haz the power, 2016-09-13 18:18:01]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/649985a530c39afcda23d1f188fa2fc92df3ac56