Issue 2340463009: fix #27353, support `@checked` covariant parameters in DDC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2340463009: fix #27353, support `@checked` covariant parameters in DDC (Closed)

Created:
4 years, 3 months ago by Jennifer Messerly

Modified:
4 years, 3 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

fix #27353, support `@checked` covariant parameters in DDC Seems pretty straightforward. Just added a simple test for now. R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/a4734d4b33f60776969b72ad475fea267c2091d5

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -17 lines)			Patch
M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	pkg/dev_compiler/pubspec.lock	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	pkg/dev_compiler/pubspec.yaml	View	2 chunks	+4 lines, -9 lines	0 comments	Download
A	pkg/dev_compiler/test/codegen/language/checked_covariant_overrides_test.dart	View	1 chunk	+36 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

4 years, 3 months ago (2016-09-15 22:42:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a4734d4b33f60776969b72ad475fea267c2091d5 (presubmit successful).