Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 2340463008: GN: support 32-bit x86 builds (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio, borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: support 32-bit x86 builds Take over Ubuntu -x86- bots. Note the change to Build-Win-MSVC-x86-Release-GN.json, which is not incidental. We'll want target_cpu="x86" there too. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2340463008 Committed: https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542 CQ_INCLUDE_TRYBOTS=master.client.skia.compile:Build-Ubuntu-Clang-x86-Debug-GN_Android-Trybot,Build-Ubuntu-GCC-x86-Release-Trybot Committed: https://skia.googlesource.com/skia/+/1fbdf98d0e9a9e5e720c77fd896a0655074e31cb

Patch Set 1 #

Patch Set 2 : updated recipes? #

Patch Set 3 : skip fiddle on x86 #

Patch Set 4 : rdynamic #

Patch Set 5 : sse #

Patch Set 6 : rebase #

Patch Set 7 : += #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -34 lines) Patch
M BUILD.gn View 1 2 1 chunk +19 lines, -15 lines 0 comments Download
M gn/BUILD.gn View 1 2 3 4 5 6 2 chunks +10 lines, -1 line 0 comments Download
M infra/bots/recipe_modules/flavor/gn_flavor.py View 1 3 chunks +6 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Ubuntu-GCC-x86-Debug.json View 1 1 chunk +28 lines, -9 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json View 1 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_compile.expected/failed_compile.json View 1 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
mtklein_C
Please review the parts you're familiar with.
4 years, 3 months ago (2016-09-15 17:24:00 UTC) #5
jcgregorio
lgtm
4 years, 3 months ago (2016-09-15 17:29:59 UTC) #6
borenet
Recipes LGTM
4 years, 3 months ago (2016-09-15 17:32:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340463008/100001
4 years, 3 months ago (2016-09-15 17:48:23 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/1949386ae00485ae92dd5608a2614b9dee417542
4 years, 3 months ago (2016-09-15 18:06:28 UTC) #11
mtklein_C
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2338173004/ by mtklein@chromium.org. ...
4 years, 3 months ago (2016-09-15 18:18:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340463008/120001
4 years, 3 months ago (2016-09-15 18:26:02 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 19:07:51 UTC) #19
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/1fbdf98d0e9a9e5e720c77fd896a0655074e31cb

Powered by Google App Engine
This is Rietveld 408576698