Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Issue 2340463005: Revert of [heap] Enable black allocation when finalizing incremental marking. (Closed)

Created:
4 years, 3 months ago by Michael Hablich
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Enable black allocation when finalizing incremental marking. (patchset #6 id:100001 of https://codereview.chromium.org/2239733002/ ) Reason for revert: Suspecting this is a roll blocker: https://codereview.chromium.org/2332343002/ # # Fatal error in ../../v8/src/heap/spaces.h, line 1618 # Check failed: capacity_ >= bytes (25429824 vs. 18446744073709551168). # Original issue's description: > [heap] Enable black allocation when finalizing incremental marking. > > BUG=chromium:630386 > > Committed: https://crrev.com/1ccc742dc326b063999670421e1da0ea124874c0 > Cr-Commit-Position: refs/heads/master@{#39382} TBR=mlippautz@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:630386 Committed: https://crrev.com/f85af183e41a7a58ccf7419b985d9247f1c18c04 Cr-Commit-Position: refs/heads/master@{#39397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Hablich
Created Revert of [heap] Enable black allocation when finalizing incremental marking.
4 years, 3 months ago (2016-09-14 02:36:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2340463005/1
4 years, 3 months ago (2016-09-14 02:36:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 02:36:21 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 02:36:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f85af183e41a7a58ccf7419b985d9247f1c18c04
Cr-Commit-Position: refs/heads/master@{#39397}

Powered by Google App Engine
This is Rietveld 408576698